[confmap] Start deprecation processor for env var expand syntax ($ENV) #10144
Conversation
| // PreventEnvVarExpansionFeatureGate is the feature gate that controls whether the collector | ||
| // supports configuring the OpenTelemetry SDK via configuration | ||
| var PreventEnvVarExpansionFeatureGate = featuregate.GlobalRegistry().MustRegister( | ||
| "confmap.preventEnvVarExpansion", |
There was a problem hiding this comment.
| "confmap.preventEnvVarExpansion", | |
| "confmap.NoBracelessEnvVars", |
I think we should refine the name a bit, since we will still allow env var expansion even after the deprecation process. We could also say NoNakedEnvVars, but I think "braceless" is a bit clearer to someone who isn't familiar with our terminology.
There was a problem hiding this comment.
Should we have a single feature gate for all changes related to the environment variable revamp? Or should we have one for each change? I am inclined to say we should have one (easier to figure out how to revert back to the old behavior without having to understand its intricacies)
There was a problem hiding this comment.
What is another change? I thought $ENV was the only thing we were deprecating
There was a problem hiding this comment.
Making types stricter and unified between ${ENV} and ${env:ENV} is the other part
| // PreventEnvVarExpansionFeatureGate is the feature gate that controls whether the collector | ||
| // supports configuring the OpenTelemetry SDK via configuration |
There was a problem hiding this comment.
| // PreventEnvVarExpansionFeatureGate is the feature gate that controls whether the collector | |
| // supports configuring the OpenTelemetry SDK via configuration | |
| // PreventEnvVarExpansionFeatureGate disables the ability to use environment variables | |
| // without wrapping the variable in braces. |
I don't think we need to explicitly call out SDK configuration here; I also don't think this has to do with the Collector's SDK instance.
There was a problem hiding this comment.
Looks like I had a bad copy-paste
Description
Starts the deprecation for support of env var expand syntax ($ENV) by adding a feature gate and a deprecation warning
Link to tracking issue
Related to #8215
Testing
Local testing