Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[internal/localhostgate] Correctly log message about local host gate #10529

Merged

Conversation

mx-psi
Copy link
Member

@mx-psi mx-psi commented Jul 3, 2024

Description

Fixes log intended to be logged when the feature gate is enabled, not disabled.

Link to tracking issue

Relates to #8510, updates #10352

Copy link

codecov bot commented Jul 3, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 92.39%. Comparing base (9405cfe) to head (11d3686).

Files Patch % Lines
internal/localhostgate/featuregate.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10529   +/-   ##
=======================================
  Coverage   92.39%   92.39%           
=======================================
  Files         393      393           
  Lines       18614    18614           
=======================================
  Hits        17199    17199           
  Misses       1058     1058           
  Partials      357      357           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mx-psi mx-psi marked this pull request as ready for review July 3, 2024 12:35
@mx-psi mx-psi requested review from a team and atoulme July 3, 2024 12:35
@mx-psi mx-psi requested a review from songy23 July 3, 2024 13:58
@codeboten codeboten merged commit 8d3c19d into open-telemetry:main Jul 3, 2024
48 of 49 checks passed
@github-actions github-actions bot added this to the next release milestone Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants