[chore] move receiver/scrapererror to scraper/scrapererror #11733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11733 +/- ##
=======================================
Coverage 91.61% 91.61%
=======================================
Files 443 443
Lines 23770 23770
=======================================
Hits 21776 21776
Misses 1620 1620
Partials 374 374 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
|
@bogdandrutu @mx-psi if you want to take a look, thank you |
mx-psi
reviewed
Nov 26, 2024
| component: receiver/scraper | ||
|
|
||
| # A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`). | ||
| note: receiver/scraperhelper package is relocated to scraper/scraperhelper and receiver/scraperhelper marked deprecated. |
There was a problem hiding this comment.
nit: Use active voice in changelogs
Suggested change
| note: receiver/scraperhelper package is relocated to scraper/scraperhelper and receiver/scraperhelper marked deprecated. | |
| note: Move receiver/scraperhelper package to scraper/scraperhelper and deprecate original receiver/scraperhelper package. |
| # (Optional) One or more lines of additional information to render under the primary note. | ||
| # These lines will be padded with 2 spaces and then inserted directly into the document. | ||
| # Use pipe (|) for multiline entries. | ||
| subtext: Aliases are added in receiver/scraperhelper to support backward compatibility but will be removed in the future. |
There was a problem hiding this comment.
I think this is already implied by the above
Suggested change
| subtext: Aliases are added in receiver/scraperhelper to support backward compatibility but will be removed in the future. |
| // SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| // Package scrapererror provides aliases for package scraper/scrapererror. | ||
| // deprecated as of [v0.115.0] |
There was a problem hiding this comment.
This needs to follow the deprecated directive format so that linters pick it up
Suggested change
| // deprecated as of [v0.115.0] | |
| // Deprecated: [v0.115.0] Use `scraper/scrapererror` instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Migrates existing scrapererror code to new scraper package. Sets aliases for receiver/scrapererror so that dependent code in contrib and elsewhere can be updated
Link to tracking issue
Relates to #11003
Testing
included unit/integration tests should suffice
Documentation
changelog yaml