[chore][docs/rfc] Add text regarding conversations #11738
+6
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mx-psi
requested review from
atoulme,
codeboten,
bogdandrutu,
djaglowski and
dmitryax
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11738 +/- ##
=======================================
Coverage 91.61% 91.61%
=======================================
Files 443 443
Lines 23770 23770
=======================================
Hits 21776 21776
Misses 1620 1620
Partials 374 374 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
andrzej-stencel
approved these changes
Nov 25, 2024
codeboten
approved these changes
Nov 25, 2024
djaglowski
approved these changes
Nov 26, 2024
evan-bradley
approved these changes
Nov 26, 2024
TylerHelmuth
approved these changes
Nov 26, 2024
| **4 business days** after making the announcement to merge the RFC. | ||
| comment. They will need to add a `rfc:final-comment-period` label to the PR, comment on the PR | ||
| and note the final comment period in the #otel-collector-dev CNCF Slack channel, and wait for at | ||
| least **4 business days** after making the announcement to merge the RFC. |
There was a problem hiding this comment.
I worry the idea of business days might be fuzzy considering the amount of approvers/maintainers in different geos.
Would it make more sense to say 5 days (this would account for plus or minus a day depending on which part of the world you're in)?
dmitryax
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Based on the experience of this process going through once, I am suggesting we make the following changes:
Link to tracking issue
Fixes #11737