Feature/enable resource attributes #365
Conversation
… on the traces in Apache and Nginx
royteeuwen
force-pushed
the
feature/enable-resource-attributes
branch
from
5d1842c to
0071c1d
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -1493,6 +1508,7 @@ | |||
| conf->nginxModuleEnabled, | |||
| (conf->nginxModuleOtelExporterEndpoint).data, | |||
| (conf->nginxModuleOtelExporterOtlpHeaders).data, | |||
| (conf->nginxModuleOtelResourceAttributes).data, | |||
Check failure
Code scanning / CodeQL
Wrong type of arguments to formatting function High
There was a problem hiding this comment.
I assume a few lines above the format string should be changed from
"(OtelExporterOtlpHeader=\"%s\")"
"(OtelResourceAttributes=\"%s\")"
"(OtelSslEnabled=\"%ld\")"
There was a problem hiding this comment.
@christophe-kamphaus-jemmic and can you merge this once I make the changes? This has been stale 6 months and I don't want to keep doing efforts while no one replies...
There was a problem hiding this comment.
I'm not a maintainer. I just saw this when I looked into #364.
You might want to join the Opentelemetry Slack channel #otel-cpp and/or the zoom meeting of the C/C++ SIG (every Wed 18:00 CEST) https://github.com/open-telemetry/community?tab=readme-ov-file#calendar and ask there.
|
@DebajitDas @kpratyus Can you please help here. |
marcalff
added
the
Webserver
|
Hey there, any blockers on this getting reviewed and merged in? I'm in a similar situation to what @royteeuwen encountered and would love to get this out in a version. |
No description provided.