Fix observable attributes drop (#2557)

open-telemetry · Feb 27, 2024 · 32196a5 · 32196a5 · github-actions · Feb 27, 2024
1 parent 84e38b2
commit 32196a5
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 5 deletions.
diff --git a/examples/common/metrics_foo_library/foo_library.cc b/examples/common/metrics_foo_library/foo_library.cc
@@ -40,9 +40,10 @@ class MeasurementFetcher
     {
       double random_incr = (rand() % 5) + 1.1;
       value_ += random_incr;
+      std::map<std::string, std::string> labels = get_random_attr();
       nostd::get<nostd::shared_ptr<opentelemetry::metrics::ObserverResultT<double>>>(
           observer_result)
-          ->Observe(value_ /*, labelkv */);
+          ->Observe(value_, labels);
     }
   }
   static double value_;

diff --git a/sdk/include/opentelemetry/sdk/metrics/observer_result.h b/sdk/include/opentelemetry/sdk/metrics/observer_result.h
@@ -26,11 +26,15 @@ class ObserverResultT final : public opentelemetry::metrics::ObserverResultT<T>
 
   ~ObserverResultT() override = default;
 
-  void Observe(T value) noexcept override { data_.insert({{}, value}); }
+  void Observe(T value) noexcept override
+  {
+    data_[MetricAttributes{{}, attributes_processor_}] = value;
+  }
 
   void Observe(T value, const opentelemetry::common::KeyValueIterable &attributes) noexcept override
   {
-    data_.insert({MetricAttributes{attributes, attributes_processor_}, value});
+    data_[MetricAttributes{attributes, attributes_processor_}] =
+        value;  // overwrites the previous value if present
   }
 
   const std::unordered_map<MetricAttributes, T, AttributeHashGenerator> &GetMeasurements()

diff --git a/sdk/src/metrics/state/observable_registry.cc b/sdk/src/metrics/state/observable_registry.cc
@@ -50,6 +50,7 @@ void ObservableRegistry::CleanupCallback(opentelemetry::metrics::ObservableInstr
 
 void ObservableRegistry::Observe(opentelemetry::common::SystemTimestamp collection_ts)
 {
+  static DefaultAttributesProcessor default_attribute_processor;
   std::lock_guard<std::mutex> lock_guard{callbacks_m_};
   for (auto &callback_wrap : callbacks_)
   {
@@ -69,7 +70,7 @@ void ObservableRegistry::Observe(opentelemetry::common::SystemTimestamp collecti
     if (value_type == InstrumentValueType::kDouble)
     {
       nostd::shared_ptr<opentelemetry::metrics::ObserverResultT<double>> ob_res(
-          new opentelemetry::sdk::metrics::ObserverResultT<double>());
+          new opentelemetry::sdk::metrics::ObserverResultT<double>(&default_attribute_processor));
       callback_wrap->callback(ob_res, callback_wrap->state);
       storage->RecordDouble(
           static_cast<opentelemetry::sdk::metrics::ObserverResultT<double> *>(ob_res.get())
@@ -79,7 +80,7 @@ void ObservableRegistry::Observe(opentelemetry::common::SystemTimestamp collecti
     else
     {
       nostd::shared_ptr<opentelemetry::metrics::ObserverResultT<int64_t>> ob_res(
-          new opentelemetry::sdk::metrics::ObserverResultT<int64_t>());
+          new opentelemetry::sdk::metrics::ObserverResultT<int64_t>(&default_attribute_processor));
       callback_wrap->callback(ob_res, callback_wrap->state);
       storage->RecordLong(
           static_cast<opentelemetry::sdk::metrics::ObserverResultT<int64_t> *>(ob_res.get())
Benchmark suite	Current: `32196a5`	Previous: `84e38b2`	Ratio
`BM_ComputeIndex/0`	`11.47370332334472` ns/iter	`5.581082372370041` ns/iter	`2.06`
`BM_ComputeIndex/1`	`19.273231264504542` ns/iter	`9.585992049955014` ns/iter	`2.01`
`BM_BaselineBuffer/1`	`1722369.1940307617` ns/iter	`853822.4697113037` ns/iter	`2.02`
Benchmark suite	Current: `32196a5`	Previous: `84e38b2`	Ratio
`BM_SpinLockThrashing/1/process_time/real_time`	`0.37532316899932594` ms/iter	`0.15675020217895508` ms/iter	`2.39`
`BM_SpinLockThrashing/4/process_time/real_time`	`1.9933867454528809` ms/iter	`0.6042412618403378` ms/iter	`3.30`
`BM_ProcYieldSpinLockThrashing/1/process_time/real_time`	`0.4049951141441377` ms/iter	`0.08553188245247274` ms/iter	`4.74`