address comments

open-telemetry · Sep 18, 2023 · 3dc902c · 3dc902c
1 parent 7d4e882
commit 3dc902c
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/exporters/prometheus/src/exporter_utils.cc b/exporters/prometheus/src/exporter_utils.cc
@@ -276,25 +276,24 @@ void PrometheusExporterUtils::SetMetricBasic(
   size_t i = 0;
   if (!labels.empty())
   {
-    metric.label.resize(labels.size());
+    metric.label.reserve(labels.size() + 2);
     for (auto const &label : labels)
     {
       auto sanitized          = SanitizeNames(label.first);
       metric.label[i].name    = sanitized;
       metric.label[i++].value = AttributeValueToString(label.second);
     }
   }
+  if (!scope) return;
   auto scope_name = scope->GetName();
   if (!scope_name.empty())
   {
-    metric.label.resize(i + 1);
     metric.label[i].name    = "otel_scope_name";
     metric.label[i++].value = scope_name;
   }
   auto scope_version = scope->GetVersion();
   if (!scope_version.empty())
   {
-    metric.label.resize(i + 1);
     metric.label[i].name    = "otel_scope_version";
     metric.label[i++].value = scope_version;
   }