Skip to content

Commit

Permalink
Add comments for project_build_tools_patch_default_imported_config.
Browse files Browse the repository at this point in the history
  • Loading branch information
owent committed Sep 19, 2023
1 parent 9135c14 commit 550c582
Showing 1 changed file with 10 additions and 0 deletions.
10 changes: 10 additions & 0 deletions cmake/tools.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,16 @@ function(project_build_tools_get_imported_location OUTPUT_VAR_NAME TARGET_NAME)
endif()
endfunction()

#[[
If we build third party packages with a different CONFIG setting from building
otel-cpp, cmake may not find a suitable file in imported targets (#705, #1359)
when linking. But on some platforms, different CONFIG settings can be used when
ABI these CONFIG settings have the same ABI. For example, on Linux, we can build
gRPC and protobuf with -DCMAKE_BUILD_TYPE=Release, but build otel-cpp with
-DCMAKE_BUILD_TYPE=Debug and links these libraries together.
The properties of imported targets can be find here:
https://cmake.org/cmake/help/latest/manual/cmake-properties.7.html#properties-on-targets
]]
function(project_build_tools_patch_default_imported_config)
set(PATCH_VARS
IMPORTED_IMPLIB
Expand Down

0 comments on commit 550c582

Please sign in to comment.