Skip to content

Commit

Permalink
[SDK] Remove unused variables from sync storage (#2294)
Browse files Browse the repository at this point in the history
  • Loading branch information
lalitb authored Sep 3, 2023
1 parent 01e6581 commit 5acaa14
Showing 1 changed file with 0 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -161,11 +161,6 @@ class SyncMetricStorage : public MetricStorage, public SyncWritableMetricStorage
InstrumentDescriptor instrument_descriptor_;
// hashmap to maintain the metrics for delta collection (i.e, collection since last Collect call)
std::unique_ptr<AttributesHashMap> attributes_hashmap_;
// unreported metrics stash for all the collectors
std::unordered_map<CollectorHandle *, std::list<std::shared_ptr<AttributesHashMap>>>
unreported_metrics_;
// last reported metrics stash for all the collectors.
std::unordered_map<CollectorHandle *, LastReportedMetrics> last_reported_metrics_;
std::function<std::unique_ptr<Aggregation>()> create_default_aggregation_;
const AttributesProcessor *attributes_processor_;
#ifdef ENABLE_METRICS_EXEMPLAR_PREVIEW
Expand Down

1 comment on commit 5acaa14

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'OpenTelemetry-cpp sdk Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: 5acaa14 Previous: 01e6581 Ratio
BM_BaselineBuffer/2 13709244.728088379 ns/iter 3881685.972213745 ns/iter 3.53
BM_LockFreeBuffer/1 3400680.517063229 ns/iter 352173.2552341683 ns/iter 9.66
BM_LockFreeBuffer/2 3907014.1315460205 ns/iter 1284010.887145996 ns/iter 3.04

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.