Skip to content

Commit

Permalink
[SDK] Restore Recordable API compatibility with versions < 1.14.0 (#2547
Browse files Browse the repository at this point in the history 
)
  • Loading branch information
@dbolduc
dbolduc authored Feb 23, 2024
1 parent 89a3d9b commit 75f34e6
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion sdk/include/opentelemetry/sdk/trace/recordable.h
View file
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ class Recordable
* Set the trace flags of the span.
* @param flags the flags to set
*/
virtual void SetTraceFlags(opentelemetry::trace::TraceFlags flags) noexcept = 0;
virtual void SetTraceFlags(opentelemetry::trace::TraceFlags /* flags */) noexcept {}

/**
* Set the spankind of the span.
Expand Down

2 comments on commit 75f34e6

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'OpenTelemetry-cpp api Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: 75f34e6 Previous: 89a3d9b Ratio
BM_ProcYieldSpinLockThrashing/2/process_time/real_time 0.47470950965283143 ms/iter 0.1542589029370437 ms/iter 3.08

This comment was automatically generated by workflow using github-action-benchmark.

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'OpenTelemetry-cpp sdk Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: 75f34e6 Previous: 89a3d9b Ratio
BM_BaselineBuffer/4 11414756.774902344 ns/iter 2515579.310494989 ns/iter 4.54
BM_LockFreeBuffer/1 11118879.318237305 ns/iter 1905774.5933532715 ns/iter 5.83
BM_LockFreeBuffer/2 10160133.838653564 ns/iter 1103517.0555114746 ns/iter 9.21
BM_LockFreeBuffer/4 10599968.433380127 ns/iter 1116308.5114722159 ns/iter 9.50

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.