[BUILD] Remove unnecessary usage/includes of nostd/type_traits (#2509)

open-telemetry · Jan 27, 2024 · 8cbe727 · 8cbe727 · github-actions · Jan 27, 2024
1 parent bbd6325
commit 8cbe727
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 6 deletions.
diff --git a/...ters/elasticsearch/include/opentelemetry/exporters/elasticsearch/es_log_record_exporter.h b/...ters/elasticsearch/include/opentelemetry/exporters/elasticsearch/es_log_record_exporter.h
@@ -7,7 +7,6 @@
 #include "opentelemetry/common/spin_lock_mutex.h"
 #include "opentelemetry/ext/http/client/http_client_factory.h"
 #include "opentelemetry/nostd/shared_ptr.h"
-#include "opentelemetry/nostd/type_traits.h"
 #include "opentelemetry/sdk/logs/exporter.h"
 #include "opentelemetry/sdk/logs/recordable.h"
 

diff --git a/exporters/ostream/include/opentelemetry/exporters/ostream/log_record_exporter.h b/exporters/ostream/include/opentelemetry/exporters/ostream/log_record_exporter.h
@@ -5,7 +5,7 @@
 
 #include "opentelemetry/common/attribute_value.h"
 #include "opentelemetry/common/spin_lock_mutex.h"
-#include "opentelemetry/nostd/type_traits.h"
+#include "opentelemetry/nostd/span.h"
 #include "opentelemetry/sdk/common/attribute_utils.h"
 #include "opentelemetry/sdk/logs/exporter.h"
 

diff --git a/exporters/ostream/include/opentelemetry/exporters/ostream/span_exporter.h b/exporters/ostream/include/opentelemetry/exporters/ostream/span_exporter.h
@@ -4,7 +4,7 @@
 #pragma once
 
 #include "opentelemetry/common/spin_lock_mutex.h"
-#include "opentelemetry/nostd/type_traits.h"
+#include "opentelemetry/nostd/span.h"
 #include "opentelemetry/sdk/trace/exporter.h"
 #include "opentelemetry/sdk/trace/span_data.h"
 #include "opentelemetry/version.h"

diff --git a/opentracing-shim/include/opentelemetry/opentracingshim/propagation.h b/opentracing-shim/include/opentelemetry/opentracingshim/propagation.h
@@ -8,7 +8,8 @@
 #include "opentelemetry/baggage/baggage.h"
 #include "opentelemetry/common/attribute_value.h"
 #include "opentelemetry/context/propagation/text_map_propagator.h"
-#include "opentelemetry/nostd/type_traits.h"
+#include "opentelemetry/nostd/function_ref.h"
+#include "opentelemetry/nostd/string_view.h"
 #include "opentracing/propagation.h"
 #include "opentracing/value.h"
 

diff --git a/sdk/include/opentelemetry/sdk/instrumentationscope/instrumentation_scope.h b/sdk/include/opentelemetry/sdk/instrumentationscope/instrumentation_scope.h
@@ -4,10 +4,10 @@
 #pragma once
 
 #include <string>
+#include <type_traits>
 
 #include "opentelemetry/common/key_value_iterable_view.h"
 #include "opentelemetry/nostd/string_view.h"
-#include "opentelemetry/nostd/type_traits.h"
 #include "opentelemetry/nostd/unique_ptr.h"
 #include "opentelemetry/nostd/variant.h"
 #include "opentelemetry/sdk/common/attribute_utils.h"
@@ -73,7 +73,7 @@ class InstrumentationScope
    */
   template <
       class ArgumentType,
-      nostd::enable_if_t<opentelemetry::common::detail::is_key_value_iterable<ArgumentType>::value>
+      std::enable_if_t<opentelemetry::common::detail::is_key_value_iterable<ArgumentType>::value>
           * = nullptr>
   static nostd::unique_ptr<InstrumentationScope> Create(nostd::string_view name,
                                                         nostd::string_view version,
Benchmark suite	Current: `8cbe727`	Previous: `bbd6325`	Ratio
`BM_NaiveSpinLockThrashing/1/process_time/real_time`	`0.7106027603149414` ms/iter	`0.08091095742855763` ms/iter	`8.78`
`BM_NaiveSpinLockThrashing/2/process_time/real_time`	`5.3873395919799805` ms/iter	`0.18701937374652633` ms/iter	`28.81`
`BM_ThreadYieldSpinLockThrashing/4/process_time/real_time`	`117.74039268493652` ms/iter	`58.7618350982666` ms/iter	`2.00`