Skip to content

Commit

Permalink
Merge branch 'main' into support_using_different_package_config_of_de…
Browse files Browse the repository at this point in the history
…pendencies_with_cmake
  • Loading branch information
esigo authored Oct 15, 2023
2 parents 81f438a + 3ff4b4c commit a529b45
Show file tree
Hide file tree
Showing 3 changed files with 16 additions and 8 deletions.
5 changes: 5 additions & 0 deletions CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -430,6 +430,11 @@ if(WITH_OTLP_GRPC OR WITH_OTLP_HTTP)
if(TARGET protobuf::protoc)
project_build_tools_get_imported_location(PROTOBUF_PROTOC_EXECUTABLE
protobuf::protoc)
# If protobuf::protoc is not a imported target, then we use the target
# directly for fallback
if(NOT PROTOBUF_PROTOC_EXECUTABLE)
set(PROTOBUF_PROTOC_EXECUTABLE protobuf::protoc)
endif()
elseif(Protobuf_PROTOC_EXECUTABLE)
# Some versions of FindProtobuf.cmake uses mixed case instead of uppercase
set(PROTOBUF_PROTOC_EXECUTABLE ${Protobuf_PROTOC_EXECUTABLE})
Expand Down
8 changes: 4 additions & 4 deletions bazel/repository.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -145,11 +145,11 @@ def opentelemetry_cpp_deps():
http_archive,
name = "curl",
build_file = "@io_opentelemetry_cpp//bazel:curl.BUILD",
sha256 = "ba98332752257b47b9dea6d8c0ad25ec1745c20424f1dd3ff2c99ab59e97cf91",
strip_prefix = "curl-7.73.0",
sha256 = "816e41809c043ff285e8c0f06a75a1fa250211bbfb2dc0a037eeef39f1a9e427",
strip_prefix = "curl-8.4.0",
urls = [
"https://curl.haxx.se/download/curl-7.73.0.tar.gz",
"https://github.com/curl/curl/releases/download/curl-7_73_0/curl-7.73.0.tar.gz",
"https://curl.haxx.se/download/curl-8.4.0.tar.gz",
"https://github.com/curl/curl/releases/download/curl-8_4_0/curl-8.4.0.tar.gz",
],
)

Expand Down
11 changes: 7 additions & 4 deletions opentracing-shim/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,13 @@ target_include_directories(
"$<INSTALL_INTERFACE:include>")

if(OPENTRACING_DIR)
include_directories(
"${CMAKE_BINARY_DIR}/${OPENTRACING_DIR}/include"
"${CMAKE_SOURCE_DIR}/${OPENTRACING_DIR}/include"
"${CMAKE_SOURCE_DIR}/${OPENTRACING_DIR}/3rd_party/include")
target_include_directories(
${this_target}
PUBLIC
"$<BUILD_INTERFACE:${PROJECT_BINARY_DIR}/${OPENTRACING_DIR}/include>"
"$<BUILD_INTERFACE:${PROJECT_SOURCE_DIR}/${OPENTRACING_DIR}/include>"
"$<BUILD_INTERFACE:${PROJECT_SOURCE_DIR}/${OPENTRACING_DIR}/3rd_party/include>"
)
target_link_libraries(${this_target} opentelemetry_api opentracing)
else()
target_link_libraries(${this_target} opentelemetry_api
Expand Down

0 comments on commit a529b45

Please sign in to comment.