format

open-telemetry · Oct 19, 2023 · eaeca30 · eaeca30
1 parent 80634bd
commit eaeca30
Showing 1 changed file with 14 additions and 13 deletions.
diff --git a/sdk/test/metrics/sum_aggregation_test.cc b/sdk/test/metrics/sum_aggregation_test.cc
@@ -128,24 +128,25 @@ TEST_P(UpDownCounterToSumFixture, Double)
 {
   bool is_matching_view = GetParam();
   MeterProvider mp;
-  auto m                                  = mp.GetMeter("meter1", "version1", "schema1");
-  std::string instrument_name             = "updowncounter1";
-  std::string instrument_name_nonmatching = "updowncounter1_nonmatching";
-  std::string instrument_desc             = "updowncounter desc";
-  std::string instrument_unit             = "ms";
+  auto m                      = mp.GetMeter("meter1", "version1", "schema1");
+  std::string instrument_name = "updowncounter1";
+  std::string instrument_desc = "updowncounter desc";
+  std::string instrument_unit = "ms";
 
   std::unique_ptr<MockMetricExporter> exporter(new MockMetricExporter());
   std::shared_ptr<MetricReader> reader{new MockMetricReader(std::move(exporter))};
   mp.AddMetricReader(reader);
 
-  std::unique_ptr<View> view{
-      new View("view1", "view1_description", instrument_unit, AggregationType::kSum)};
-  std::unique_ptr<InstrumentSelector> instrument_selector{new InstrumentSelector(
-      InstrumentType::kUpDownCounter,
-      is_matching_view ? instrument_name : instrument_name_nonmatching, instrument_unit)};
-  std::unique_ptr<MeterSelector> meter_selector{new MeterSelector("meter1", "version1", "schema1")};
-  mp.AddView(std::move(instrument_selector), std::move(meter_selector), std::move(view));
-
+  if (is_matching_view)
+  {
+    std::unique_ptr<View> view{
+        new View("view1", "view1_description", instrument_unit, AggregationType::kSum)};
+    std::unique_ptr<InstrumentSelector> instrument_selector{
+        new InstrumentSelector(InstrumentType::kUpDownCounter, instrument_name, instrument_unit)};
+    std::unique_ptr<MeterSelector> meter_selector{
+        new MeterSelector("meter1", "version1", "schema1")};
+    mp.AddView(std::move(instrument_selector), std::move(meter_selector), std::move(view));
+  }
   auto h = m->CreateDoubleUpDownCounter(instrument_name, instrument_desc, instrument_unit);
 
   h->Add(5, {});