Remove service_name, per configuration PR 68

open-telemetry/opentelemetry-configuration#68
open-telemetry · Mar 4, 2024 · ecf6f1c · ecf6f1c
1 parent 91fccb3
commit ecf6f1c
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 10 deletions.
diff --git a/sdk/include/opentelemetry/sdk/configuration/attributes_configuration.h b/sdk/include/opentelemetry/sdk/configuration/attributes_configuration.h
@@ -16,7 +16,6 @@ namespace configuration
 class AttributesConfiguration
 {
 public:
-  std::string service_name;
   std::map<std::string, std::string> kv_map;
 };
 

diff --git a/sdk/src/configuration/configuration_factory.cc b/sdk/src/configuration/configuration_factory.cc
@@ -752,15 +752,9 @@ static std::unique_ptr<AttributesConfiguration> ParseAttributesConfiguration(
 
     OTEL_INTERNAL_LOG_DEBUG(
         "ParseAttributesConfiguration() name = " << name << ", value = " << string_value);
-    if (name == "service.name")
-    {
-      model->service_name = name;
-    }
-    else
-    {
-      std::pair<std::string, std::string> entry(name, string_value);
-      model->kv_map.insert(entry);
-    }
+
+    std::pair<std::string, std::string> entry(name, string_value);
+    model->kv_map.insert(entry);
   }
 
   return model;
-Original file line number
+Diff line change
@@ Expand Up / @@ -16,7 +16,6 @@ namespace configuration @@
     class AttributesConfiguration
     {
     public:
-      std::string service_name;
       std::map<std::string, std::string> kv_map;
     };
@@ Expand Down @@