Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support to use different cmake package CONFIG of dependencies. #2251

Closed
owent opened this issue Aug 1, 2023 · 3 comments · Fixed by #2263
Closed

Support to use different cmake package CONFIG of dependencies. #2251

owent opened this issue Aug 1, 2023 · 3 comments · Fixed by #2263
Assignees
@owent
Labels
do-not-stale triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@owent
Copy link
Member

owent commented Aug 1, 2023

Is your feature request related to a problem?

Some issues (#705, #1359) was created before, and as talked in #2163, create a separate issue here.

Describe the solution you'd like
Patch imported target in cmake CONFIG packages to enable users to use prebuilt packages with different CONFIG settings.
@owent owent self-assigned this Aug 1, 2023
@github-actions github-actions bot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Aug 1, 2023
@owent owent mentioned this issue Aug 1, 2023
Merged
3 tasks
@esigo esigo added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Aug 9, 2023
@ThomsonTan
Copy link
Contributor

Does this mean we patch target files from other packages?

Patch imported target in cmake CONFIG packages to enable users to use prebuilt packages with different CONFIG settings.

@owent
Copy link
Member Author

owent commented Aug 11, 2023

Does this mean we patch target files from other packages?

Patch imported target in cmake CONFIG packages to enable users to use prebuilt packages with different CONFIG settings.

For example, when user built packages with -DCMAKE_BUILD_TYPE=RelWithDebInfo , we can allow otel-cpp is built with -DCMAKE_BUILD_TYPE=Debug on Linux and macOS, and with -DCMAKE_BUILD_TYPE=Release on Windows.

@owent owent mentioned this issue Aug 15, 2023
Merged
3 tasks
@github-actions
Copy link

This issue was marked as stale due to lack of activity.

@github-actions github-actions bot added the Stale label Oct 11, 2023
@owent owent added do-not-stale and removed Stale labels Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@owent owent

Labels
do-not-stale triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[BUILD] Support to use different cmake package CONFIG of dependencies. owent/opentelemetry-cpp
3 participants
@ThomsonTan @owent @esigo