-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUILD] Support to use different cmake package CONFIG of dependencies. #2263
[BUILD] Support to use different cmake package CONFIG of dependencies. #2263
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2263 +/- ##
=======================================
Coverage 87.41% 87.41%
=======================================
Files 199 199
Lines 6018 6018
=======================================
Hits 5260 5260
Misses 758 758 |
…pendencies_with_cmake
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the change.
Please add some comment to describe what feature it actually provides (or bug it fixes),
with an example of when it is useful, and how to use it.
Please assume the reader has no or little knowledge of CMake, and make the example as explicit as possible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, thanks for the comments.
See two suggestions.
…nt_package_config_of_dependencies_with_cmake
Thanks, the spell errors are fixed. |
…pendencies_with_cmake
…pendencies_with_cmake
…pendencies_with_cmake
…pendencies_with_cmake
…pendencies_with_cmake
Added the please-review label. This PR looks ok to me, but given this affects makefiles with CMake in general, maybe @lalitb @ThomsonTan or @esigo can look at it also. |
…pendencies_with_cmake
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for the PR :)
…pendencies_with_cmake
Fixes #2251
Changes
For significant contributions please make sure you have completed the following items:
CHANGELOG.md
updated for non-trivial changes