Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test BasicCurlHttpTests.FinishInAsyncCallback is unstable in CI. #3172

Closed
marcalff opened this issue Nov 26, 2024 · 1 comment · Fixed by #3204
Closed

Test BasicCurlHttpTests.FinishInAsyncCallback is unstable in CI. #3172

marcalff opened this issue Nov 26, 2024 · 1 comment · Fixed by #3204
Labels
bug Something isn't working triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@marcalff
Copy link
Member

[ RUN      ] BasicCurlHttpTests.FinishInAsyncCallback
ext/test/http/curl_http_test.cc:525: Failure
Value of: handlers[i]->got_response_
  Actual: false
Expected: true

[  FAILED  ] BasicCurlHttpTests.FinishInAsyncCallback (5 ms)
[----------] 15 tests from BasicCurlHttpTests (7643 ms total)

[----------] Global test environment tear-down
[==========] 15 tests from 1 test suite ran. (7643 ms total)
[  PASSED  ] 14 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] BasicCurlHttpTests.FinishInAsyncCallback

 1 FAILED TEST
===========================================================================

To investigate, unclear if this is a failure due to the test itself, or the production code tested.

@marcalff marcalff added the bug Something isn't working label Nov 26, 2024
@github-actions github-actions bot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Nov 26, 2024
@owent
Copy link
Member

owent commented Dec 2, 2024

Not sure if it's related to CPU cache line. Should we try to declare got_response_ as atomic<bool> to see if it will happen again?

@marcalff marcalff added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants