Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDK] Tracer provider shutdown blocks in-definitively #3187

Closed
marcalff opened this issue Dec 4, 2024 · 0 comments · Fixed by #3191
Closed

[SDK] Tracer provider shutdown blocks in-definitively #3187

marcalff opened this issue Dec 4, 2024 · 0 comments · Fixed by #3191
Assignees
Labels
bug Something isn't working triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@marcalff
Copy link
Member

marcalff commented Dec 4, 2024

The following code, in file sdk/src/trace/tracer_provider.cc:

bool TracerProvider::Shutdown() noexcept
{
  return context_->Shutdown();
}

does not take a timeout parameter.

TracerProvider::Shutdown() will block in-definitively if unsent spans are present.

This prevents an application to shutdown opentelemetry-cpp.

@marcalff marcalff added the bug Something isn't working label Dec 4, 2024
@marcalff marcalff self-assigned this Dec 4, 2024
@github-actions github-actions bot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Dec 4, 2024
marcalff added a commit to marcalff/opentelemetry-cpp that referenced this issue Dec 5, 2024
@marcalff marcalff added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant