Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDK] Tracer provider shutdown blocks in-definitively #3191

Merged
merged 2 commits into from
Dec 7, 2024

Conversation

marcalff
Copy link
Member

@marcalff marcalff commented Dec 5, 2024

Fixes #3187

Changes

Please provide a brief description of the changes here.

  • Fixed several ::Shutdown() methods, where the timeout parameter was missing
  • Fixed implementation to forward the timeout parameter downstream, from providers to processors to exporters

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

Copy link

netlify bot commented Dec 5, 2024

Deploy Preview for opentelemetry-cpp-api-docs canceled.

Name Link
🔨 Latest commit 1945bf3
🔍 Latest deploy log https://app.netlify.com/sites/opentelemetry-cpp-api-docs/deploys/67543a714c87490008c69874

Copy link

codecov bot commented Dec 5, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 87.83%. Comparing base (6218a24) to head (1945bf3).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...lemetry/exporters/memory/in_memory_span_exporter.h 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3191      +/-   ##
==========================================
- Coverage   87.86%   87.83%   -0.03%     
==========================================
  Files         195      195              
  Lines        6153     6154       +1     
==========================================
- Hits         5406     5405       -1     
- Misses        747      749       +2     
Files with missing lines Coverage Δ
...e/opentelemetry/sdk/metrics/push_metric_exporter.h 100.00% <ø> (ø)
sdk/include/opentelemetry/sdk/trace/processor.h 100.00% <ø> (ø)
sdk/src/logs/logger_provider.cc 90.91% <100.00%> (ø)
sdk/src/metrics/meter_context.cc 76.06% <100.00%> (ø)
sdk/src/metrics/meter_provider.cc 87.18% <100.00%> (ø)
sdk/src/trace/tracer_provider.cc 89.37% <100.00%> (ø)
...lemetry/exporters/memory/in_memory_span_exporter.h 80.96% <0.00%> (-8.52%) ⬇️

@marcalff marcalff marked this pull request as ready for review December 5, 2024 20:17
@marcalff marcalff requested a review from a team as a code owner December 5, 2024 20:17
Copy link
Member

@owent owent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and thanks.

@marcalff marcalff merged commit 762b73d into open-telemetry:main Dec 7, 2024
57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[SDK] Tracer provider shutdown blocks in-definitively
2 participants