Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[API] Add InstrumentationScope attributes in MeterProvider::GetMeter() #2224
[API] Add InstrumentationScope attributes in MeterProvider::GetMeter() #2224
Changes from all commits
fdbef73
63fde43
b1b735f
d2a107a
e287db5
a754d54
51852cc
88d31da
3853b9d
b404d40
7610dc9
e3b5f07
673af34
acad9e7
d4ec4af
2125acb
8f9f1ec
1ac42b6
a53ff4e
f812c9c
9d0a39a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit - some code duplication, which can be moved to a separate utils method. But don't see it really required to fix