-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUILD] Need fine-grained HAVE_CPP_STDLIB #2304
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2304 +/- ##
=======================================
Coverage 87.45% 87.45%
=======================================
Files 199 199
Lines 5997 5997
=======================================
Hits 5244 5244
Misses 753 753
|
ThomsonTan
reviewed
Sep 11, 2023
ThomsonTan
reviewed
Sep 11, 2023
ThomsonTan
reviewed
Sep 11, 2023
Closed
owent
approved these changes
Sep 27, 2023
lalitb
approved these changes
Sep 28, 2023
Co-authored-by: Lalit Kumar Bhasin <[email protected]>
Co-authored-by: Lalit Kumar Bhasin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1071
Changes
Fixed the following issues with unit tests:
In
nostd/span_test.cc
:(2)
in https://en.cppreference.com/w/cpp/container/span/span, this is undefined behavior.In
url_parser_test
:Fixed namespace pollution in the
API
header files:#define HAVE_SPAN
is replaced by#define OPENTELEMETRY_HAVE_SPAN
#define HAVE_CPP_STDLIB
is replaced by#define OPENTELEMETRY_STL_VERSION=<version>
Improved the granularity of the CMake WITH_STL option:
WITH_STL
was either a "all" (C++20, or C++17 with extra code) or nothing choice.WITH_STL
can gradually pick witch parts of the STL to use, withOFF
,CXX11
,CXX14
,CXX17
,CXX20
orCXX23
options.Fixed compiling options pollution in
CMake
:CMAKE_CXX_STANDARD
to specific values, possibly interfering with existing applications makefiles and compiling options.CMAKE_CXX_STANDARD
is no longer overwritten. TheCMAKE_CXX_STANDARD
setting, if any, or thestdc++
compiler options, if any, provided by the caller are honored.For significant contributions please make sure you have completed the following items:
CHANGELOG.md
updated for non-trivial changes