-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[API] Add a new AddLink() operation to Span #2380
[API] Add a new AddLink() operation to Span #2380
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2380 +/- ##
=======================================
Coverage 87.43% 87.43%
=======================================
Files 199 199
Lines 6030 6030
=======================================
Hits 5272 5272
Misses 758 758
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Nicely done. few nit comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for the PR :)
## Changes Update spec-compliance-matrix.md for C++: * `Get a Tracer with scope attributes` implemented by: * open-telemetry/opentelemetry-cpp#2371 * `Links can be recorded after span creation` implemented by: * open-telemetry/opentelemetry-cpp#2380 * `get_meter accepts attributes` implemented by: * open-telemetry/opentelemetry-cpp#2224
## Changes Update spec-compliance-matrix.md for C++: * `Get a Tracer with scope attributes` implemented by: * open-telemetry/opentelemetry-cpp#2371 * `Links can be recorded after span creation` implemented by: * open-telemetry/opentelemetry-cpp#2380 * `get_meter accepts attributes` implemented by: * open-telemetry/opentelemetry-cpp#2224
Fixes #2361
Changes
Please provide a brief description of the changes here.
API
Span::AddLink() adds a single link to a span.API
Span::AddLinks() adds multiple links to a span.For significant contributions please make sure you have completed the following items:
CHANGELOG.md
updated for non-trivial changes