Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EXPORTER] Async exporting for otlp grpc #2407
[EXPORTER] Async exporting for otlp grpc #2407
Changes from 29 commits
3e840b0
9b3b057
74175a3
3cc2776
aeb7b55
25419f6
e7f119a
4301f23
1862010
5fef32a
0dc3f73
0951836
a9c538d
ae7dc10
57ebf34
a3c78d2
0dadc1c
ac964f3
5c7c352
54fb976
692cfed
49c3b7d
be4bcd1
3a53ed9
7c66023
6587bd3
4c892a7
63489fa
05525fd
d07cdf6
cdb8816
7dd1bd3
1cc3f1c
d0f1add
daccf33
d86cb39
95f7614
0f4c77f
277b73b
37f7dbd
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this be moved to
otlp_grpc_exporter_options.h
as a central place?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Users use the factory and
otlp_grpc*_options.h
to create OTLP gRPC exporters, but I think users do not need to know the internal classOtlpGrpcClient
?