Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Metrics] Make context optional for histogram instruments in Metrics SDK #2416

Merged

Remove extra if

e05d12f
Select commit
Loading
Failed to load commit list.
Merged

[Metrics] Make context optional for histogram instruments in Metrics SDK #2416

Remove extra if
e05d12f
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 29, 2023 in 0s

87.06% (-0.35%) compared to 71d0e50

View this Pull Request on Codecov

87.06% (-0.35%) compared to 71d0e50

Details

Codecov Report

Merging #2416 (e05d12f) into main (71d0e50) will decrease coverage by 0.35%.
The diff coverage is 56.33%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2416      +/-   ##
==========================================
- Coverage   87.41%   87.06%   -0.35%     
==========================================
  Files         199      199              
  Lines        6052     6079      +27     
==========================================
+ Hits         5290     5292       +2     
- Misses        762      787      +25     
Files Coverage Δ
api/include/opentelemetry/metrics/noop.h 41.18% <ø> (+3.93%) ⬆️
...i/include/opentelemetry/metrics/sync_instruments.h 100.00% <100.00%> (ø)
...clude/opentelemetry/sdk/metrics/sync_instruments.h 100.00% <ø> (+19.52%) ⬆️
sdk/src/metrics/meter.cc 61.45% <100.00%> (ø)
sdk/src/metrics/sync_instruments.cc 65.84% <53.09%> (-13.05%) ⬇️

... and 1 file with indirect coverage changes