-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUILD] Fix references to trace namespace to be fully qualified #2422
Conversation
Signed-off-by: Bogdan Drutu <[email protected]>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2422 +/- ##
=======================================
Coverage 87.06% 87.06%
=======================================
Files 199 199
Lines 6079 6079
=======================================
Hits 5292 5292
Misses 787 787
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix.
@bogdandrutu Thanks for the fix!!
I went through all "trace::" in the repository, and it seems that those not-fully-qualified namespace in api (eg) and those in .cc (eg) does not cause the same issue. However, I assume those in the |
Fixes #2417