Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUILD] Add DLL build CI pipeline with CXX20 #2465

Merged
merged 3 commits into from
Jan 19, 2024

Conversation

ThomsonTan
Copy link
Contributor

@ThomsonTan ThomsonTan commented Dec 20, 2023

Fixes # (issue)

Changes

Please provide a brief description of the changes here.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

Copy link

codecov bot commented Dec 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (589dd2a) 87.09% compared to head (ee0ec09) 87.09%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2465   +/-   ##
=======================================
  Coverage   87.09%   87.09%           
=======================================
  Files         200      200           
  Lines        6103     6103           
=======================================
  Hits         5315     5315           
  Misses        788      788           

@ThomsonTan ThomsonTan changed the title Add DLL build CI pipeline with CXX20 [BUILD] Add DLL build CI pipeline with CXX20 Dec 21, 2023
Copy link
Member

@marcalff marcalff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is still draft, what is missing ?

LGTM as is.

@ThomsonTan ThomsonTan marked this pull request as ready for review January 19, 2024 02:41
@ThomsonTan ThomsonTan requested a review from a team January 19, 2024 02:41
@marcalff marcalff merged commit 2b5c2b4 into open-telemetry:main Jan 19, 2024
46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants