[opentracing-shim] Provide span for opentracing shim inject #2535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karusher
force-pushed
the
propagation_shim
branch
from
fbae783 to
e5bece9
Compare
The various propagation injectors will attempt to retrieve the
Span from the context that is provided in the api call:
void Inject(context::propagation::TextMapCarrier &carrier,
const context::Context &context) noexcept override
The shim will provide the RuntimeContext augmented with the baggage
to the Inject method. Unfortunately, the shim does not add the span
to the RuntimeContext. It does not instantiate a Scope.
This commit adds a Span to the context passed into Inject by
modifying the shim.
karusher
force-pushed
the
propagation_shim
branch
from
e5bece9 to
94758b5
Compare
|
cc @chusitoo |
Not a subject matter expert, but this looks like a very valid fix IMHO, and it is more or less equivalent to how the Java folks do it for their OT shim too. |
marcalff
changed the title
lalitb
approved these changes
Feb 26, 2024
malkia
added a commit
to malkia/opentelemetry-cpp
that referenced
this pull request
Feb 27, 2024
Provide span for opentracing shim inject (open-telemetry#2535)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We noticed that the propagation headers were not being populated correctly when using the opentracing-shim. The
trace-id, span-id and trace flags were missing.
The various propagation injectors will attempt to retrieve the Span from the context that is provided in the api call:
void Inject(context::propagation::TextMapCarrier &carrier,
const context::Context &context) noexcept override
The shim will provide the RuntimeContext augmented with the baggage to the Inject method. Unfortunately, the shim does not add the span to the RuntimeContext. It does not instantiate a Scope.
This commit adds a Span to the context passed into Inject by modifying the shim.
Fixes # (issue)
Changes
Please provide a brief description of the changes here.
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes