Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[API] Add synchronous gauge #3029

Merged
merged 10 commits into from
Oct 30, 2024

Apply suggestions from code review

56bdf77
Select commit
Loading
Failed to load commit list.
Merged

[API] Add synchronous gauge #3029

Apply suggestions from code review
56bdf77
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 30, 2024 in 0s

87.88% (+0.76%) compared to 497eaf4

View this Pull Request on Codecov

87.88% (+0.76%) compared to 497eaf4

Details

Codecov Report

Attention: Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 87.88%. Comparing base (497eaf4) to head (56bdf77).
Report is 150 commits behind head on main.

Files with missing lines Patch % Lines
sdk/src/metrics/state/metric_collector.cc 60.00% 2 Missing ⚠️
...etry/sdk/metrics/aggregation/default_aggregation.h 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3029      +/-   ##
==========================================
+ Coverage   87.12%   87.88%   +0.76%     
==========================================
  Files         200      195       -5     
  Lines        6109     6137      +28     
==========================================
+ Hits         5322     5393      +71     
+ Misses        787      744      -43     
Files with missing lines Coverage Δ
api/include/opentelemetry/metrics/meter.h 100.00% <ø> (ø)
api/include/opentelemetry/metrics/noop.h 41.18% <ø> (ø)
...i/include/opentelemetry/metrics/sync_instruments.h 100.00% <ø> (ø)
sdk/include/opentelemetry/sdk/metrics/meter.h 57.15% <ø> (ø)
...clude/opentelemetry/sdk/metrics/sync_instruments.h 100.00% <ø> (ø)
sdk/src/metrics/meter.cc 62.36% <ø> (+0.91%) ⬆️
sdk/src/metrics/sync_instruments.cc 65.84% <ø> (ø)
...etry/sdk/metrics/aggregation/default_aggregation.h 70.13% <0.00%> (ø)
sdk/src/metrics/state/metric_collector.cc 87.10% <60.00%> (-5.76%) ⬇️

... and 94 files with indirect coverage changes