Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Code health] Include what you use cleanup, part 5 #3140

Merged
merged 22 commits into from
Nov 27, 2024

Conversation

marcalff
Copy link
Member

@marcalff marcalff commented Nov 13, 2024

Contributes to #2054

Changes

Please provide a brief description of the changes here.

  • continued the include-what-you-use cleanup
  • total number of warnings decreased from 37 in branch main, to 2 in this PR.
  • CI is now enforcing a pass/fail check, with some tolerance (<= 10 warnings)

Note that the cleanup is not completed, as some optional parts (OTLP GRPC) are not covered yet by the build in CI.
This will be handled in subsequent PRs.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

Copy link

netlify bot commented Nov 13, 2024

Deploy Preview for opentelemetry-cpp-api-docs ready!

Name Link
🔨 Latest commit 04082ca
🔍 Latest deploy log https://app.netlify.com/sites/opentelemetry-cpp-api-docs/deploys/6745dae3662d940008ebe58c
😎 Deploy Preview https://deploy-preview-3140--opentelemetry-cpp-api-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Nov 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.86%. Comparing base (8d45dec) to head (04082ca).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3140   +/-   ##
=======================================
  Coverage   87.86%   87.86%           
=======================================
  Files         195      195           
  Lines        6151     6151           
=======================================
  Hits         5404     5404           
  Misses        747      747           
Files with missing lines Coverage Δ
api/include/opentelemetry/nostd/variant.h 66.67% <ø> (ø)
...telemetry/exporters/memory/in_memory_metric_data.h 100.00% <ø> (ø)
exporters/memory/src/in_memory_metric_data.cc 85.00% <ø> (ø)
...rs/memory/src/in_memory_metric_exporter_factory.cc 100.00% <ø> (ø)
...xporters/memory/test/in_memory_metric_data_test.cc 100.00% <ø> (ø)
...ters/memory/test/in_memory_metric_exporter_test.cc 100.00% <ø> (ø)
exporters/memory/test/in_memory_span_data_test.cc 100.00% <ø> (ø)
...orters/memory/test/in_memory_span_exporter_test.cc 100.00% <ø> (ø)
exporters/ostream/test/ostream_log_test.cc 96.18% <ø> (ø)
exporters/ostream/test/ostream_metric_test.cc 100.00% <ø> (ø)
... and 2 more

@marcalff marcalff marked this pull request as ready for review November 14, 2024 23:37
@marcalff marcalff requested a review from a team as a code owner November 14, 2024 23:37
@marcalff marcalff changed the title Include what you use cleanup, part 5 [Code health] Include what you use cleanup, part 5 Nov 14, 2024
@marcalff
Copy link
Member Author

@open-telemetry/cpp-contrib-approvers Ready for review.

@marcalff marcalff added the pr:please-review This PR is ready for review label Nov 14, 2024
@marcalff
Copy link
Member Author

@ThomsonTan @lalitb @esigo @owent

Any chance to approve this cleanup, so it goes into release 1.18.0 ?

exporters/otlp/test/otlp_file_client_test.cc Outdated Show resolved Hide resolved
exporters/otlp/src/otlp_file_client.cc Show resolved Hide resolved
exporters/otlp/test/otlp_http_metric_exporter_test.cc Outdated Show resolved Hide resolved
@marcalff
Copy link
Member Author

@owent

Thanks for the review.
All comments fixed, PTAL.

Copy link
Member

@esigo esigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
thanks for the PR :)

Copy link
Member

@owent owent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and thanks.

@marcalff marcalff merged commit d15da3b into open-telemetry:main Nov 27, 2024
57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:please-review This PR is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants