-
Notifications
You must be signed in to change notification settings - Fork 443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Code health] Include what you use cleanup, part 5 #3140
Conversation
✅ Deploy Preview for opentelemetry-cpp-api-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3140 +/- ##
=======================================
Coverage 87.86% 87.86%
=======================================
Files 195 195
Lines 6151 6151
=======================================
Hits 5404 5404
Misses 747 747
|
@open-telemetry/cpp-contrib-approvers Ready for review. |
@ThomsonTan @lalitb @esigo @owent Any chance to approve this cleanup, so it goes into release 1.18.0 ? |
Thanks for the review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
thanks for the PR :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and thanks.
Contributes to #2054
Changes
Please provide a brief description of the changes here.
Note that the cleanup is not completed, as some optional parts (OTLP GRPC) are not covered yet by the build in CI.
This will be handled in subsequent PRs.
For significant contributions please make sure you have completed the following items:
CHANGELOG.md
updated for non-trivial changes