-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Add cppcheck in the build #3151
Conversation
✅ Deploy Preview for opentelemetry-cpp-api-docs canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3151 +/- ##
=======================================
Coverage 87.83% 87.83%
=======================================
Files 195 195
Lines 6146 6146
=======================================
Hits 5398 5398
Misses 748 748
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the CI.
Is this a subset of the part 2 change? |
Yes. Once part 1 is merged to main, part 2 PR will only contain part 2 (the code fixes). |
Fixes #2297
Changes
For significant contributions please make sure you have completed the following items:
CHANGELOG.md
updated for non-trivial changes