-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TEST] Build the singleton test on windows. #3183
Merged
marcalff
merged 13 commits into
open-telemetry:main
from
marcalff:fix_singleton_test_build
Dec 17, 2024
Merged
[TEST] Build the singleton test on windows. #3183
marcalff
merged 13 commits into
open-telemetry:main
from
marcalff:fix_singleton_test_build
Dec 17, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for opentelemetry-cpp-api-docs canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3183 +/- ##
==========================================
+ Coverage 87.82% 87.83% +0.02%
==========================================
Files 195 195
Lines 6154 6154
==========================================
+ Hits 5404 5405 +1
+ Misses 750 749 -1 |
marcalff
changed the title
Build the singleton test on windows.
[TEST] Build the singleton test on windows.
Dec 3, 2024
ThomsonTan
reviewed
Dec 4, 2024
lalitb
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #2534
Note that the original issue in #2534 is not fixed.
This change only adds unit tests to reproduce the issue, and show the current failure in windows.
Changes
Please provide a brief description of the changes here.
For significant contributions please make sure you have completed the following items:
CHANGELOG.md
updated for non-trivial changes