Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUILD] Add cxx feature detections #3203

Merged
merged 6 commits into from
Dec 18, 2024

Conversation

owent
Copy link
Member

@owent owent commented Dec 13, 2024

Fixes #3200

Changes

  • Add feature detection headers and use macro to checking C++20 deatures.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@owent owent requested a review from a team as a code owner December 13, 2024 09:58
Copy link

netlify bot commented Dec 13, 2024

Deploy Preview for opentelemetry-cpp-api-docs canceled.

Name Link
🔨 Latest commit 68c3a7b
🔍 Latest deploy log https://app.netlify.com/sites/opentelemetry-cpp-api-docs/deploys/6761d0851b120e00089ab5d8

Copy link

codecov bot commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.82%. Comparing base (902ee88) to head (68c3a7b).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3203      +/-   ##
==========================================
- Coverage   87.83%   87.82%   -0.01%     
==========================================
  Files         195      195              
  Lines        6154     6154              
==========================================
- Hits         5405     5404       -1     
- Misses        749      750       +1     

see 1 file with indirect coverage changes

@marcalff marcalff changed the title Add cxx feature dections Add cxx feature detections Dec 13, 2024
Copy link
Member

@marcalff marcalff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix.

@marcalff marcalff changed the title Add cxx feature detections [BUILD] Add cxx feature detections Dec 18, 2024
@marcalff marcalff merged commit d9ad23e into open-telemetry:main Dec 18, 2024
57 checks passed
@owent owent deleted the add_cxx_feature_dections branch December 20, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not all compiler support all C++20's components when using -std=c++20
2 participants