Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI on ubuntu-latest #3207

Merged
merged 3 commits into from
Dec 17, 2024
Merged

Conversation

marcalff
Copy link
Member

@marcalff marcalff commented Dec 16, 2024

Fixes #3206

Changes

Please provide a brief description of the changes here.

  • Upgraded gcc version from 10 to 12 for some builds
  • Set explicitly ubuntu-22.04 on some other builds, due to specific setup (gcov, libc++)
  • Temporarily raise the acceptable include-what-you-use errors
    • New iwyu errors are raised because the tool version was upgraded.
    • New iwyu reports to be fixed independently

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

Copy link

netlify bot commented Dec 16, 2024

Deploy Preview for opentelemetry-cpp-api-docs canceled.

Name Link
🔨 Latest commit 60c79e2
🔍 Latest deploy log https://app.netlify.com/sites/opentelemetry-cpp-api-docs/deploys/676066e731fa5800081f4ef7

@ThomsonTan
Copy link
Contributor

Is ubuntu-latest updated?

@marcalff
Copy link
Member Author

Is ubuntu-latest updated?

Yes: actions/runner-images#10636

@marcalff marcalff marked this pull request as ready for review December 16, 2024 17:48
@marcalff marcalff requested a review from a team as a code owner December 16, 2024 17:48
Copy link

codecov bot commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.83%. Comparing base (6ed0651) to head (60c79e2).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3207      +/-   ##
==========================================
+ Coverage   87.82%   87.83%   +0.02%     
==========================================
  Files         195      195              
  Lines        6154     6154              
==========================================
+ Hits         5404     5405       +1     
+ Misses        750      749       -1     

see 1 file with indirect coverage changes

@marcalff marcalff added pr:please-review This PR is ready for review issue:blocking This issue is preventing other fixes labels Dec 16, 2024
@marcalff marcalff merged commit b741815 into open-telemetry:main Dec 17, 2024
57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue:blocking This issue is preventing other fixes pr:please-review This PR is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI] Build failures after ubuntu-latest upgrade to 24.04
3 participants