Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tag_suffix for accounting service #1848

Conversation

alanwest
Copy link
Member

@alanwest alanwest commented Dec 17, 2024

The Helm chart generates a kubernetes manifest that expects the suffix of the account service's image to be accountingservice.

containers:
- name: accountingservice
image: 'ghcr.io/open-telemetry/demo:1.12.0-accountingservice'

Few options to fix this:

  1. This PR
  2. Fix the Helm chart to use the new name
  3. Others?

I'd be happy to follow up on whatever solution people would prefer.

If people like the solution in this PR, I think it would also make sense to change the directory name and all contained files back to accountingservice for consistency - e.g., /src/accounting becomes /src/accountingservice. Thoughts?

I see now that there is an effort to remove the term service from the names of the services in #1788. I recommend leaving the tag_suffix for services untouched for now.

@alanwest alanwest requested a review from a team as a code owner December 17, 2024 18:19
@alanwest alanwest mentioned this pull request Dec 17, 2024
3 tasks
@puckpuck
Copy link
Contributor

Closing this as the nightly releases are not part of anything we would deploy on Kubernetes or do with a fresh repo clone + make a start. The Kubernetes deployments that we support are fixed to the last good release, which is 1.12.0 right now. The nighlies will carry the new names for services as we change and we need to continue to do that for development reasons.

@puckpuck puckpuck closed this Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants