Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[recommendation] rename recommendationservice to recommendation #1865

Merged

Conversation

puckpuck
Copy link
Contributor

@puckpuck puckpuck commented Dec 23, 2024

Changes

Renames recommendationservice to recommendation

This is part of getting all services renamed based on the overall #1788 effort for all components in the demo.

Merge Requirements

For new features contributions, please make sure you have completed the following
essential items:

  • CHANGELOG.md updated to document new feature additions
  • Appropriate documentation updates in the docs
  • Appropriate Helm chart updates in the helm-charts

Maintainers will not merge until the above have been completed. If you're unsure
which docs need to be changed ping the
@open-telemetry/demo-approvers.

@puckpuck puckpuck requested a review from a team as a code owner December 23, 2024 04:26
@github-actions github-actions bot added docs-update-required Requires documentation update helm-update-required Requires an update to the Helm chart when released labels Dec 23, 2024
Copy link
Member

@mviitane mviitane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Runs fine.

@julianocosta89 julianocosta89 merged commit 2210b5b into open-telemetry:main Dec 23, 2024
31 of 32 checks passed
@puckpuck puckpuck deleted the rename.recommendationservice branch December 24, 2024 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-update-required Requires documentation update helm-update-required Requires an update to the Helm chart when released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants