[aws] default to use Semantic Convention 1.28 and remove option Legacy #2437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
muhammad-othman,
Oberon00,
rypdal and
srprash
github-actions
bot
added
comp:instrumentation.aws
alanwest
approved these changes
Dec 20, 2024
rajkumar-rangaraj
approved these changes
Dec 20, 2024
muhammad-othman
approved these changes
Dec 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Design discussion issue # Continuation of #2367
Changes
Update the OpenTelemetry.*.AWS libraries to to use Semantic Convention 1.28 and remove the option
SemanticConventionVerisons.LegacyBackground
We determined that #2367, should not change Semantic Conventions by default, allowing users a non-breaking way to test opting in-to 1.28.
This is a fast follow up PR that removes
SemanticConventionVersions.Legacyand changes the default to SemanticConventionVersions.V1_28_0. This PR is to be released as a Release Candidate.This follows the release strategy for other contrib packages that have made similar breaking changes around Semantic Convention stabilization.
Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial changes