Merge pull request #766 from open-telemetry/elixir-exception-atom

Exception should be atom
open-telemetry · Sep 9, 2024 · 9042483 · 9042483
2 parents 18f0d7f + 1d9c4e5
commit 9042483
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/apps/opentelemetry_api/lib/open_telemetry/span.ex b/apps/opentelemetry_api/lib/open_telemetry/span.ex
@@ -146,7 +146,7 @@ defmodule OpenTelemetry.Span do
        Exception.format_stacktrace(trace)}
     ]
 
-    add_event(span_ctx, "exception", exception_attributes ++ attributes)
+    add_event(span_ctx, :exception, exception_attributes ++ attributes)
   end
 
   def record_exception(_, _, _, _), do: false

diff --git a/test/otel_tests.exs b/test/otel_tests.exs
@@ -259,7 +259,7 @@ defmodule OtelTests do
                             :infinity,
                             0,
                             [
-                              {:event, _, "exception", ^attributes}
+                              {:event, _, :exception, ^attributes}
                             ]
                           }
                         )}
-Original file line number
+Diff line change
@@ Expand Up / @@ -259,7 +259,7 @@ defmodule OtelTests do @@
                                 :infinity,
 ,
                                 [
-                                  {:event, _, "exception", ^attributes}
+                                  {:event, _, :exception, ^attributes}
                                 ]
                               }
                             )}
@@ Expand Down @@