-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow wildcard for view instrument name #624
Conversation
ac9b33a
to
ef5dea1
Compare
Codecov ReportAll modified lines are covered by tests ✅ 📢 Thoughts on this report? Let us know!. |
ef5dea1
to
8ce874b
Compare
@tsloughter by working on this I notice that the |
@albertored oh yea, and definitely time to extend the type. |
@tsloughter perfect, I'll add it to this PR if it's ok |
@tsloughter done, but there is still a failing test |
960e7a9
to
f87e160
Compare
@tsloughter rebased to fix conflicts by this time I hit the w3c flakyness :-D |
@albertored looks good. rebase on latest |
cfbf7e9
to
710de34
Compare
@tsloughter rebased |
Complete the implementation of wildcard views