Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid warning log causing FORMATTER CRASH #774

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

hoyon
Copy link
Contributor

@hoyon hoyon commented Sep 23, 2024

When this warning is triggered due to opentelemetry_exporter not being installed, the warning causes a formatter crash error as below.

This is because format args are supplied but are not used in the format string.

2024-09-23T16:40:10.836262+01:00 warning: FORMATTER CRASH: {"OTLP exporter module `opentelemetry_exporter` not found. Verify you have included the `opentelemetry_exporter` dependency.",[opentelemetry_exporter]}

Copy link

codecov bot commented Sep 23, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 73.19%. Comparing base (f80cd08) to head (bda6844).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
apps/opentelemetry/src/otel_exporter.erl 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #774   +/-   ##
=======================================
  Coverage   73.19%   73.19%           
=======================================
  Files          64       64           
  Lines        1940     1940           
=======================================
  Hits         1420     1420           
  Misses        520      520           
Flag Coverage Δ
api 69.90% <ø> (ø)
elixir 17.32% <ø> (ø)
erlang 74.51% <0.00%> (ø)
exporter 73.06% <ø> (ø)
sdk 77.30% <0.00%> (ø)
zipkin 54.16% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tsloughter tsloughter merged commit 0325c19 into open-telemetry:main Sep 23, 2024
14 of 15 checks passed
@hoyon hoyon deleted the patch-1 branch September 24, 2024 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants