Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor bumps #786

Merged
merged 5 commits into from
Oct 6, 2024
Merged

Minor bumps #786

merged 5 commits into from
Oct 6, 2024

Conversation

tsloughter
Copy link
Member

I got scared after #784 and made these minor version bumps... API probably doesn't need to be at all. SDK now that its fixed to work with older export versions also could probably be a patch. But.. feels safer.

Note I retired the previous patch versions from hex.

Copy link

codecov bot commented Oct 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.20%. Comparing base (4dd6b60) to head (fee4ce7).
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #786      +/-   ##
==========================================
+ Coverage   73.19%   73.20%   +0.01%     
==========================================
  Files          64       64              
  Lines        1940     1941       +1     
==========================================
+ Hits         1420     1421       +1     
  Misses        520      520              
Flag Coverage Δ
api 69.90% <ø> (ø)
elixir 17.32% <ø> (ø)
erlang 74.53% <100.00%> (+0.01%) ⬆️
exporter 73.17% <ø> (+0.10%) ⬆️
sdk 77.30% <100.00%> (ø)
zipkin 54.16% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tsloughter tsloughter merged commit ba180b6 into open-telemetry:main Oct 6, 2024
18 checks passed
@tsloughter tsloughter deleted the minor-bumps branch October 6, 2024 17:15
@shaharz
Copy link

shaharz commented Oct 8, 2024

We're seeing issues with the zipkin exporter in 1.5.0:

span exporter threw exception: exporter=:opentelemetry_zipkin exception error: undefined function opentelemetry_zipkin:export/3
  in function  otel_batch_processor:export/3 (/build/deps/opentelemetry/src/otel_batch_processor.erl, line 444)
  in call from otel_batch_processor:send_spans/3 (/build/deps/opentelemetry/src/otel_batch_processor.erl, line 430)

Looks like this change was reverted in a later commit, was that intentional? Would be great to have it back 😄

@tsloughter
Copy link
Member Author

Argh, thanks, apparently we don't have integration tests for zipkin and the batch processor :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants