-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor bumps #786
Minor bumps #786
Conversation
93e0ca8
to
6454395
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #786 +/- ##
==========================================
+ Coverage 73.19% 73.20% +0.01%
==========================================
Files 64 64
Lines 1940 1941 +1
==========================================
+ Hits 1420 1421 +1
Misses 520 520
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
We're seeing issues with the zipkin exporter in 1.5.0:
Looks like this change was reverted in a later commit, was that intentional? Would be great to have it back 😄 |
Argh, thanks, apparently we don't have integration tests for zipkin and the batch processor :( |
I got scared after #784 and made these minor version bumps... API probably doesn't need to be at all. SDK now that its fixed to work with older export versions also could probably be a patch. But.. feels safer.
Note I retired the previous patch versions from hex.