fix(opentelemetry-operator): set version label with image tag if provided #1461
Conversation
jdiegosierra
changed the title
jdiegosierra
changed the title
jdiegosierra
changed the title
charts/opentelemetry-operator/conf/crds/crd-opentelemetrycollector.yaml
Outdated
Show resolved
Hide resolved
jdiegosierra
force-pushed
the
fix-version-label
branch
from
c9cff89 to
17d5bd4
Compare
jdiegosierra
force-pushed
the
fix-version-label
branch
from
17d5bd4 to
778cfc2
Compare
| {{/* | ||
| Common labels | ||
| */}} | ||
| {{- define "opentelemetry-operator.labels" -}} | ||
| helm.sh/chart: {{ include "opentelemetry-operator.chart" . }} | ||
| {{ include "opentelemetry-operator.selectorLabels" . }} | ||
| {{- if .Chart.AppVersion }} |
There was a problem hiding this comment.
.Chart.AppVersion will be always defined so its not needed
…ided (open-telemetry#1461) * Create app version helper * Fix description * Bump version --------- Co-authored-by: Tyler Helmuth <[email protected]>
|
This breaks using digest in tag: one or more objects failed to apply, reason: Secret "opentelemetry-operator-controller-manager-service-cert" is invalid: [metadata.labels: Invalid value: "v0.116.0@sha256:11edfad24ead5f48140eb12aea642a2716ca0cd9e63eae3851f39c4477f3c2c2": must be no more than 63 characters, metadata.labels: Invalid value: "v0.116.0@sha256:11edfad24ead5f48140eb12aea642a2716ca0cd9e63eae3851f39c4477f3c2c2": a valid label must be an empty string or consist of alphanumeric characters, '-', '' or '.', and must start and end with an alphanumeric character (e.g. 'MyValue', or 'my_value', or '12345', regex used for validation is '(([A-Za-z0-9][-A-Za-z0-9.]*)?[A-Za-z0-9])?')]. |
If
.Values.manager.image.tagis provided with a different version other thanappVersion,label app.kubernetes.io/versionstill showsappVersion.