Add null check to StrictContextStorage (#5954)

open-telemetry · Nov 6, 2023 · 1ecc919 · 1ecc919
1 parent 19196a0
commit 1ecc919
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/context/src/main/java/io/opentelemetry/context/StrictContextStorage.java b/context/src/main/java/io/opentelemetry/context/StrictContextStorage.java
@@ -23,6 +23,7 @@
 import static java.lang.Thread.currentThread;
 
 import io.opentelemetry.context.internal.shaded.WeakConcurrentMap;
+import java.lang.ref.Reference;
 import java.util.Arrays;
 import java.util.List;
 import java.util.concurrent.ConcurrentHashMap;
@@ -266,7 +267,9 @@ List<CallerStackTrace> drainPendingCallers() {
     public void run() {
       try {
         while (!Thread.interrupted()) {
-          CallerStackTrace caller = map.remove(remove());
+          Reference<? extends Scope> reference = remove();
+          // on openj9 ReferenceQueue.remove can return null
+          CallerStackTrace caller = reference != null ? map.remove(reference) : null;
           if (caller != null && !caller.closed) {
             logger.log(
                 Level.SEVERE, "Scope garbage collected before being closed.", callerError(caller));