-
Notifications
You must be signed in to change notification settings - Fork 853
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replaced hardcoded test host name with the one properly resolved by OS #3770
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3770 +/- ##
============================================
+ Coverage 89.08% 89.17% +0.08%
- Complexity 3917 3961 +44
============================================
Files 470 471 +1
Lines 12344 12478 +134
Branches 1208 1231 +23
============================================
+ Hits 10997 11127 +130
+ Misses 945 939 -6
- Partials 402 412 +10
Continue to review full report at Codecov.
|
/easycla |
nice, i'll have to see if this can help with situation in instrumentation repo, currently we have some loose assertions to account for similar issue |
Sorry, everybody. |
Never mind. It seems that my personal CLA request got approved. Reopening this again with all passed tests! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Looks good.
This fixes:
#3619