Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced hardcoded test host name with the one properly resolved by OS #3770

Merged
merged 4 commits into from
Oct 20, 2021

Conversation

tnevolin
Copy link
Contributor

This fixes:
#3619

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Oct 19, 2021

CLA Signed

The committers are authorized under a signed CLA.

@codecov
Copy link

codecov bot commented Oct 19, 2021

Codecov Report

Merging #3770 (e3eb59b) into main (7f6ac89) will increase coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #3770      +/-   ##
============================================
+ Coverage     89.08%   89.17%   +0.08%     
- Complexity     3917     3961      +44     
============================================
  Files           470      471       +1     
  Lines         12344    12478     +134     
  Branches       1208     1231      +23     
============================================
+ Hits          10997    11127     +130     
+ Misses          945      939       -6     
- Partials        402      412      +10     
Impacted Files Coverage Δ
...entelemetry/sdk/trace/data/DelegatingSpanData.java 82.41% <0.00%> (ø)
...telemetry/sdk/trace/export/BatchSpanProcessor.java 90.78% <0.00%> (+0.70%) ⬆️
...ntelemetry/sdk/extension/resources/OsResource.java 90.69% <0.00%> (+4.65%) ⬆️
...ava/io/opentelemetry/sdk/internal/RateLimiter.java 100.00% <0.00%> (+5.88%) ⬆️
...metry/sdk/extension/resources/ProcessResource.java 87.50% <0.00%> (+6.25%) ⬆️
...nsion/incubator/trace/data/DelegatingSpanData.java 89.55% <0.00%> (+7.13%) ⬆️
...elemetry/sdk/extension/resources/HostResource.java 92.30% <0.00%> (+15.38%) ⬆️
...dk/extension/resources/ProcessRuntimeResource.java 100.00% <0.00%> (+16.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f6ac89...e3eb59b. Read the comment docs.

@tnevolin
Copy link
Contributor Author

/easycla

@trask
Copy link
Member

trask commented Oct 20, 2021

nice, i'll have to see if this can help with situation in instrumentation repo, currently we have some loose assertions to account for similar issue

@tnevolin tnevolin closed this Oct 20, 2021
@tnevolin tnevolin reopened this Oct 20, 2021
@tnevolin tnevolin closed this Oct 20, 2021
@tnevolin
Copy link
Contributor Author

Sorry, everybody.
I need to close it and open a new one to kick EasyCLA test again. I'll put forward link to new one.

@tnevolin tnevolin reopened this Oct 20, 2021
@tnevolin
Copy link
Contributor Author

Never mind. It seems that my personal CLA request got approved. Reopening this again with all passed tests!

Copy link
Contributor

@jkwatson jkwatson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good.

@jkwatson jkwatson merged commit 9cea4ef into open-telemetry:main Oct 20, 2021
@tnevolin tnevolin deleted the feature/3619 branch October 20, 2021 20:22
This was referenced Dec 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants