Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exponential Histogram support to the Prometheus exporter #6015

Merged
merged 3 commits into from
Jan 3, 2024

Code review fulfillment (part 2)

f1f027d
Select commit
Loading
Failed to load commit list.
Merged

Exponential Histogram support to the Prometheus exporter #6015

Code review fulfillment (part 2)
f1f027d
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch failed Dec 17, 2023 in 1s

76.67% of diff hit (target 80.00%)

View this Pull Request on Codecov

76.67% of diff hit (target 80.00%)

Annotations

Check warning on line 88 in exporters/prometheus/src/main/java/io/opentelemetry/exporter/prometheus/Otel2PrometheusConverter.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

exporters/prometheus/src/main/java/io/opentelemetry/exporter/prometheus/Otel2PrometheusConverter.java#L88 

Added line #L88 was not covered by tests

Check warning on line 96 in exporters/prometheus/src/main/java/io/opentelemetry/exporter/prometheus/Otel2PrometheusConverter.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

exporters/prometheus/src/main/java/io/opentelemetry/exporter/prometheus/Otel2PrometheusConverter.java#L96 

Added line #L96 was not covered by tests

Check warning on line 103 in exporters/prometheus/src/main/java/io/opentelemetry/exporter/prometheus/Otel2PrometheusConverter.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

exporters/prometheus/src/main/java/io/opentelemetry/exporter/prometheus/Otel2PrometheusConverter.java#L103 

Added line #L103 was not covered by tests

Check warning on line 110 in exporters/prometheus/src/main/java/io/opentelemetry/exporter/prometheus/Otel2PrometheusConverter.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

exporters/prometheus/src/main/java/io/opentelemetry/exporter/prometheus/Otel2PrometheusConverter.java#L110 

Added line #L110 was not covered by tests

Check warning on line 131 in exporters/prometheus/src/main/java/io/opentelemetry/exporter/prometheus/Otel2PrometheusConverter.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

exporters/prometheus/src/main/java/io/opentelemetry/exporter/prometheus/Otel2PrometheusConverter.java#L131 

Added line #L131 was not covered by tests

Check warning on line 140 in exporters/prometheus/src/main/java/io/opentelemetry/exporter/prometheus/Otel2PrometheusConverter.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

exporters/prometheus/src/main/java/io/opentelemetry/exporter/prometheus/Otel2PrometheusConverter.java#L140 

Added line #L140 was not covered by tests

Check warning on line 149 in exporters/prometheus/src/main/java/io/opentelemetry/exporter/prometheus/Otel2PrometheusConverter.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

exporters/prometheus/src/main/java/io/opentelemetry/exporter/prometheus/Otel2PrometheusConverter.java#L149 

Added line #L149 was not covered by tests

Check warning on line 157 in exporters/prometheus/src/main/java/io/opentelemetry/exporter/prometheus/Otel2PrometheusConverter.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

exporters/prometheus/src/main/java/io/opentelemetry/exporter/prometheus/Otel2PrometheusConverter.java#L157 

Added line #L157 was not covered by tests

Check warning on line 162 in exporters/prometheus/src/main/java/io/opentelemetry/exporter/prometheus/Otel2PrometheusConverter.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

exporters/prometheus/src/main/java/io/opentelemetry/exporter/prometheus/Otel2PrometheusConverter.java#L162 

Added line #L162 was not covered by tests

Check warning on line 164 in exporters/prometheus/src/main/java/io/opentelemetry/exporter/prometheus/Otel2PrometheusConverter.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

exporters/prometheus/src/main/java/io/opentelemetry/exporter/prometheus/Otel2PrometheusConverter.java#L164 

Added line #L164 was not covered by tests

Check warning on line 259 in exporters/prometheus/src/main/java/io/opentelemetry/exporter/prometheus/Otel2PrometheusConverter.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

exporters/prometheus/src/main/java/io/opentelemetry/exporter/prometheus/Otel2PrometheusConverter.java#L259 

Added line #L259 was not covered by tests

Check warning on line 262 in exporters/prometheus/src/main/java/io/opentelemetry/exporter/prometheus/Otel2PrometheusConverter.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

exporters/prometheus/src/main/java/io/opentelemetry/exporter/prometheus/Otel2PrometheusConverter.java#L262 

Added line #L262 was not covered by tests

Check warning on line 264 in exporters/prometheus/src/main/java/io/opentelemetry/exporter/prometheus/Otel2PrometheusConverter.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

exporters/prometheus/src/main/java/io/opentelemetry/exporter/prometheus/Otel2PrometheusConverter.java#L264 

Added line #L264 was not covered by tests

Check warning on line 266 in exporters/prometheus/src/main/java/io/opentelemetry/exporter/prometheus/Otel2PrometheusConverter.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

exporters/prometheus/src/main/java/io/opentelemetry/exporter/prometheus/Otel2PrometheusConverter.java#L266 

Added line #L266 was not covered by tests

Check warning on line 314 in exporters/prometheus/src/main/java/io/opentelemetry/exporter/prometheus/Otel2PrometheusConverter.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

exporters/prometheus/src/main/java/io/opentelemetry/exporter/prometheus/Otel2PrometheusConverter.java#L314 

Added line #L314 was not covered by tests

Check warning on line 316 in exporters/prometheus/src/main/java/io/opentelemetry/exporter/prometheus/Otel2PrometheusConverter.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

exporters/prometheus/src/main/java/io/opentelemetry/exporter/prometheus/Otel2PrometheusConverter.java#L316 

Added line #L316 was not covered by tests

Check warning on line 321 in exporters/prometheus/src/main/java/io/opentelemetry/exporter/prometheus/Otel2PrometheusConverter.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

exporters/prometheus/src/main/java/io/opentelemetry/exporter/prometheus/Otel2PrometheusConverter.java#L318-L321 

Added lines #L318 - L321 were not covered by tests

Check warning on line 325 in exporters/prometheus/src/main/java/io/opentelemetry/exporter/prometheus/Otel2PrometheusConverter.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

exporters/prometheus/src/main/java/io/opentelemetry/exporter/prometheus/Otel2PrometheusConverter.java#L323-L325 

Added lines #L323 - L325 were not covered by tests

Check warning on line 329 in exporters/prometheus/src/main/java/io/opentelemetry/exporter/prometheus/Otel2PrometheusConverter.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

exporters/prometheus/src/main/java/io/opentelemetry/exporter/prometheus/Otel2PrometheusConverter.java#L329 

Added line #L329 was not covered by tests

Check warning on line 333 in exporters/prometheus/src/main/java/io/opentelemetry/exporter/prometheus/Otel2PrometheusConverter.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

exporters/prometheus/src/main/java/io/opentelemetry/exporter/prometheus/Otel2PrometheusConverter.java#L331-L333 

Added lines #L331 - L333 were not covered by tests

Check warning on line 380 in exporters/prometheus/src/main/java/io/opentelemetry/exporter/prometheus/Otel2PrometheusConverter.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

exporters/prometheus/src/main/java/io/opentelemetry/exporter/prometheus/Otel2PrometheusConverter.java#L380 

Added line #L380 was not covered by tests

Check warning on line 383 in exporters/prometheus/src/main/java/io/opentelemetry/exporter/prometheus/Otel2PrometheusConverter.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

exporters/prometheus/src/main/java/io/opentelemetry/exporter/prometheus/Otel2PrometheusConverter.java#L382-L383 

Added lines #L382 - L383 were not covered by tests

Check warning on line 395 in exporters/prometheus/src/main/java/io/opentelemetry/exporter/prometheus/Otel2PrometheusConverter.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

exporters/prometheus/src/main/java/io/opentelemetry/exporter/prometheus/Otel2PrometheusConverter.java#L395 

Added line #L395 was not covered by tests

Check warning on line 400 in exporters/prometheus/src/main/java/io/opentelemetry/exporter/prometheus/Otel2PrometheusConverter.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

exporters/prometheus/src/main/java/io/opentelemetry/exporter/prometheus/Otel2PrometheusConverter.java#L397-L400 

Added lines #L397 - L400 were not covered by tests

Check warning on line 480 in exporters/prometheus/src/main/java/io/opentelemetry/exporter/prometheus/Otel2PrometheusConverter.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

exporters/prometheus/src/main/java/io/opentelemetry/exporter/prometheus/Otel2PrometheusConverter.java#L480 

Added line #L480 was not covered by tests
View more details on Codecov