fix(deps): update dependency com.google.protobuf:protobuf-bom to v4

[renovate]

This PR contains the following updates:

Package	Change	Age	Adoption	Passing	Confidence
com.google.protobuf:protobuf-bom (source)	3.25.4 -> 4.28.2

---

Release Notes

protocolbuffers/protobuf (com.google.protobuf:protobuf-bom)

v3.25.5

---

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

---

EDIT from Jack:
Rebase checkbox removed since rebasing will cause custom changes to this PR to be lost.

---

This PR was generated by Mend Renovate. View the repository job log.

[breedx-splk]

I fiddled around with this for a while and couldn't get it working. It looks like the base class of generated messages changes (source?) and it seems like the toByteArray() (at least on grpc Status class) goes away.

[jack-berg]

It looks like the base class of generated messages changes (grpc/grpc-java#11015) and it seems like the toByteArray() (at least on grpc Status class) goes away.

The base class for messages changed from GeneratedMessageV3 to GeneratedMessage. The Status class comes from com.google.api.grpc:proto-google-common-protos, which hasn't upgraded to protobuf-bom v4 yet, and so there is a transitive dependency conflict which leads to the missing toByteArray method. We'll need to wait for com.google.api.grpc:proto-google-common-protos to upgrade, or maybe generate the classes ourselves if we're impatient, before upgrading.

Luckily, com.google.protobuf:protobuf-bom is only used in tests.

[jack-berg]

Looks like more work is still needed: protocolbuffers/protobuf#17247

[renovate]

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

[jack-berg]

Two blockers stand in the way of merging this:

1. opentelemetry-proto-java still depends on an older version of grpc java. Need to bump those dependencies and cut a release: Bump grpc and protobuf versions opentelemetry-proto-java#17. Not clear how we cut a release since opentelemetry-proto-java versions are currently coupled to opentelemetry-proto releases.
2. Armeria has a transitive on grpc-version and has not yet upgraded to the 1.68.0 version which uses protobuf v4. This causes tests to fail which use armeria. Tracking issue: Compatibility with armeria and grpc 4.26.0 versions is broken. line/armeria#5504

Basically, we have to wait for all our dependencies which rely on grpc-java to upgrade to 1.68.0 and cut a release. Not clear if any others remain besides the two I've noted here. What a mess.

[jack-berg]

Now that opentelemetry-proto-java:1.4.0-alpha is released, we're actually good to move forward with this. Note that I appear to have been incorrect about the requirement that armeria also update to 4.26.0.

This comment explains why.

Anyway, the build currently passes as long as I exclude the /exporter/otlp/profiles module which has a bunch of breaking changes. @jhalliday is working on this so we have a path to updating to protobuf v4.27.x and opentelemetry-proto-java v1.4.0 by next week.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.31%. Comparing base (c71bd9d) to head (71c7207).
Report is 8 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff            @@
##               main    #6295   +/-   ##
=========================================
  Coverage     90.31%   90.31%           
  Complexity     6594     6594           
=========================================
  Files           729      729           
  Lines         19784    19784           
  Branches       1945     1945           
=========================================
  Hits          17867    17867           
  Misses         1325     1325           
  Partials        592      592           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[jkwatson]

whoa. build finally passing! Is this ready to merge?

[jack-berg]

This change was bundled into #6906. We needed to update the version of opentelemetry-proto and the version of com.google.protobuf:protobuf-bom in lockstep. Closing this PR, finally...