Require exporter timeouts to be positive

exporters/otlp/all/src/main/java/io/opentelemetry/exporter/otlp/http/logs/OtlpHttpLogRecordExporterBuilder.java

@@ -56,7 +56,7 @@ public final class OtlpHttpLogRecordExporterBuilder {
    */
   public OtlpHttpLogRecordExporterBuilder setTimeout(long timeout, TimeUnit unit) {
     requireNonNull(unit, "unit");
-    checkArgument(timeout >= 0, "timeout must be non-negative");
+    checkArgument(timeout > 0, "timeout must be positive");
     delegate.setTimeout(timeout, unit);
     return this;
   }
@@ -78,7 +78,7 @@ public OtlpHttpLogRecordExporterBuilder setTimeout(Duration timeout) {
    */
   public OtlpHttpLogRecordExporterBuilder setConnectTimeout(long timeout, TimeUnit unit) {
     requireNonNull(unit, "unit");
-    checkArgument(timeout >= 0, "timeout must be non-negative");
+    checkArgument(timeout > 0, "timeout must be positive");
     delegate.setConnectTimeout(timeout, unit);
     return this;
   }

exporters/otlp/all/src/main/java/io/opentelemetry/exporter/otlp/http/metrics/OtlpHttpMetricExporterBuilder.java

@@ -70,7 +70,7 @@ public final class OtlpHttpMetricExporterBuilder {
    */
   public OtlpHttpMetricExporterBuilder setTimeout(long timeout, TimeUnit unit) {
     requireNonNull(unit, "unit");
-    checkArgument(timeout >= 0, "timeout must be non-negative");
+    checkArgument(timeout > 0, "timeout must be positive");
     delegate.setTimeout(timeout, unit);
     return this;
   }
@@ -92,7 +92,7 @@ public OtlpHttpMetricExporterBuilder setTimeout(Duration timeout) {
    */
   public OtlpHttpMetricExporterBuilder setConnectTimeout(long timeout, TimeUnit unit) {
     requireNonNull(unit, "unit");
-    checkArgument(timeout >= 0, "timeout must be non-negative");
+    checkArgument(timeout > 0, "timeout must be positive");
     delegate.setConnectTimeout(timeout, unit);
     return this;
   }

exporters/otlp/all/src/main/java/io/opentelemetry/exporter/otlp/http/trace/OtlpHttpSpanExporterBuilder.java

@@ -56,7 +56,7 @@ public final class OtlpHttpSpanExporterBuilder {
    */
   public OtlpHttpSpanExporterBuilder setTimeout(long timeout, TimeUnit unit) {
     requireNonNull(unit, "unit");
-    checkArgument(timeout >= 0, "timeout must be non-negative");
+    checkArgument(timeout > 0, "timeout must be positive");
     delegate.setTimeout(timeout, unit);
     return this;
   }
@@ -78,7 +78,7 @@ public OtlpHttpSpanExporterBuilder setTimeout(Duration timeout) {
    */
   public OtlpHttpSpanExporterBuilder setConnectTimeout(long timeout, TimeUnit unit) {
     requireNonNull(unit, "unit");
-    checkArgument(timeout >= 0, "timeout must be non-negative");
+    checkArgument(timeout > 0, "timeout must be positive");
     delegate.setConnectTimeout(timeout, unit);
     return this;
   }

exporters/otlp/all/src/main/java/io/opentelemetry/exporter/otlp/logs/OtlpGrpcLogRecordExporterBuilder.java

@@ -92,7 +92,7 @@ public OtlpGrpcLogRecordExporterBuilder setChannel(ManagedChannel channel) {
    */
   public OtlpGrpcLogRecordExporterBuilder setTimeout(long timeout, TimeUnit unit) {
     requireNonNull(unit, "unit");
-    checkArgument(timeout >= 0, "timeout must be non-negative");
+    checkArgument(timeout > 0, "timeout must be positive");
     delegate.setTimeout(timeout, unit);
     return this;
   }
@@ -115,7 +115,7 @@ public OtlpGrpcLogRecordExporterBuilder setTimeout(Duration timeout) {
    */
   public OtlpGrpcLogRecordExporterBuilder setConnectTimeout(long timeout, TimeUnit unit) {
     requireNonNull(unit, "unit");
-    checkArgument(timeout >= 0, "timeout must be non-negative");
+    checkArgument(timeout > 0, "timeout must be positive");
     delegate.setConnectTimeout(timeout, unit);
     return this;
   }

exporters/otlp/all/src/main/java/io/opentelemetry/exporter/otlp/metrics/OtlpGrpcMetricExporterBuilder.java

@@ -106,7 +106,7 @@ public OtlpGrpcMetricExporterBuilder setChannel(ManagedChannel channel) {
    */
   public OtlpGrpcMetricExporterBuilder setTimeout(long timeout, TimeUnit unit) {
     requireNonNull(unit, "unit");
-    checkArgument(timeout >= 0, "timeout must be non-negative");
+    checkArgument(timeout > 0, "timeout must be positive");
     delegate.setTimeout(timeout, unit);
     return this;
   }
@@ -129,7 +129,7 @@ public OtlpGrpcMetricExporterBuilder setTimeout(Duration timeout) {
    */
   public OtlpGrpcMetricExporterBuilder setConnectTimeout(long timeout, TimeUnit unit) {
     requireNonNull(unit, "unit");
-    checkArgument(timeout >= 0, "timeout must be non-negative");
+    checkArgument(timeout > 0, "timeout must be positive");
     delegate.setConnectTimeout(timeout, unit);
     return this;
   }

exporters/otlp/all/src/main/java/io/opentelemetry/exporter/otlp/trace/OtlpGrpcSpanExporterBuilder.java

@@ -88,7 +88,7 @@ public OtlpGrpcSpanExporterBuilder setChannel(ManagedChannel channel) {
    */
   public OtlpGrpcSpanExporterBuilder setTimeout(long timeout, TimeUnit unit) {
     requireNonNull(unit, "unit");
-    checkArgument(timeout >= 0, "timeout must be non-negative");
+    checkArgument(timeout > 0, "timeout must be positive");
     delegate.setTimeout(timeout, unit);
     return this;
   }
@@ -111,7 +111,7 @@ public OtlpGrpcSpanExporterBuilder setTimeout(Duration timeout) {
    */
   public OtlpGrpcSpanExporterBuilder setConnectTimeout(long timeout, TimeUnit unit) {
     requireNonNull(unit, "unit");
-    checkArgument(timeout >= 0, "timeout must be non-negative");
+    checkArgument(timeout > 0, "timeout must be positive");
     delegate.setConnectTimeout(timeout, unit);
     return this;
   }

exporters/otlp/testing-internal/src/main/java/io/opentelemetry/exporter/otlp/testing/internal/AbstractGrpcTelemetryExporterTest.java

@@ -814,9 +814,9 @@ void overrideHost() {
   @Test
   @SuppressWarnings("PreferJavaTimeOverload")
   void validConfig() {
-    assertThatCode(() -> exporterBuilder().setTimeout(0, TimeUnit.MILLISECONDS))
+    assertThatCode(() -> exporterBuilder().setTimeout(1, TimeUnit.MILLISECONDS))
         .doesNotThrowAnyException();
-    assertThatCode(() -> exporterBuilder().setTimeout(Duration.ofMillis(0)))
+    assertThatCode(() -> exporterBuilder().setTimeout(Duration.ofMillis(1)))
         .doesNotThrowAnyException();
     assertThatCode(() -> exporterBuilder().setTimeout(10, TimeUnit.MILLISECONDS))
         .doesNotThrowAnyException();
@@ -848,9 +848,9 @@ void validConfig() {
   @Test
   @SuppressWarnings({"PreferJavaTimeOverload", "NullAway"})
   void invalidConfig() {
-    assertThatThrownBy(() -> exporterBuilder().setTimeout(-1, TimeUnit.MILLISECONDS))
+    assertThatThrownBy(() -> exporterBuilder().setTimeout(0, TimeUnit.MILLISECONDS))
         .isInstanceOf(IllegalArgumentException.class)
-        .hasMessage("timeout must be non-negative");
+        .hasMessage("timeout must be positive");
     assertThatThrownBy(() -> exporterBuilder().setTimeout(1, null))
         .isInstanceOf(NullPointerException.class)
         .hasMessage("unit");

exporters/otlp/testing-internal/src/main/java/io/opentelemetry/exporter/otlp/testing/internal/AbstractHttpTelemetryExporterTest.java

@@ -728,18 +728,18 @@ void proxy() {
   @Test
   @SuppressWarnings("PreferJavaTimeOverload")
   void validConfig() {
-    assertThatCode(() -> exporterBuilder().setTimeout(0, TimeUnit.MILLISECONDS))
+    assertThatCode(() -> exporterBuilder().setTimeout(1, TimeUnit.MILLISECONDS))
         .doesNotThrowAnyException();
-    assertThatCode(() -> exporterBuilder().setTimeout(Duration.ofMillis(0)))
+    assertThatCode(() -> exporterBuilder().setTimeout(Duration.ofMillis(1)))
         .doesNotThrowAnyException();
     assertThatCode(() -> exporterBuilder().setTimeout(10, TimeUnit.MILLISECONDS))
         .doesNotThrowAnyException();
     assertThatCode(() -> exporterBuilder().setTimeout(Duration.ofMillis(10)))
         .doesNotThrowAnyException();
 
-    assertThatCode(() -> exporterBuilder().setConnectTimeout(0, TimeUnit.MILLISECONDS))
+    assertThatCode(() -> exporterBuilder().setConnectTimeout(1, TimeUnit.MILLISECONDS))
         .doesNotThrowAnyException();
-    assertThatCode(() -> exporterBuilder().setConnectTimeout(Duration.ofMillis(0)))
+    assertThatCode(() -> exporterBuilder().setConnectTimeout(Duration.ofMillis(1)))
         .doesNotThrowAnyException();
     assertThatCode(() -> exporterBuilder().setConnectTimeout(10, TimeUnit.MILLISECONDS))
         .doesNotThrowAnyException();
@@ -771,19 +771,19 @@ void validConfig() {
   @Test
   @SuppressWarnings({"PreferJavaTimeOverload", "NullAway"})
   void invalidConfig() {
-    assertThatThrownBy(() -> exporterBuilder().setTimeout(-1, TimeUnit.MILLISECONDS))
+    assertThatThrownBy(() -> exporterBuilder().setTimeout(0, TimeUnit.MILLISECONDS))
         .isInstanceOf(IllegalArgumentException.class)
-        .hasMessage("timeout must be non-negative");
+        .hasMessage("timeout must be positive");
     assertThatThrownBy(() -> exporterBuilder().setTimeout(1, null))
         .isInstanceOf(NullPointerException.class)
         .hasMessage("unit");
     assertThatThrownBy(() -> exporterBuilder().setTimeout(null))
         .isInstanceOf(NullPointerException.class)
         .hasMessage("timeout");
 
-    assertThatThrownBy(() -> exporterBuilder().setConnectTimeout(-1, TimeUnit.MILLISECONDS))
+    assertThatThrownBy(() -> exporterBuilder().setConnectTimeout(0, TimeUnit.MILLISECONDS))
         .isInstanceOf(IllegalArgumentException.class)
-        .hasMessage("timeout must be non-negative");
+        .hasMessage("timeout must be positive");
     assertThatThrownBy(() -> exporterBuilder().setConnectTimeout(1, null))
         .isInstanceOf(NullPointerException.class)
         .hasMessage("unit");

exporters/zipkin/src/main/java/io/opentelemetry/exporter/zipkin/ZipkinSpanExporterBuilder.java

@@ -155,7 +155,7 @@ public ZipkinSpanExporterBuilder setCompression(String compressionMethod) {
    */
   public ZipkinSpanExporterBuilder setReadTimeout(long timeout, TimeUnit unit) {
     requireNonNull(unit, "unit");
-    checkArgument(timeout >= 0, "timeout must be non-negative");
+    checkArgument(timeout > 0, "timeout must be positive");
     this.readTimeoutMillis = unit.toMillis(timeout);
     return this;
   }

exporters/zipkin/src/test/java/io/opentelemetry/exporter/zipkin/ZipkinSpanExporterTest.java

@@ -137,9 +137,9 @@ void testShutdown() throws IOException {
   @SuppressWarnings({"PreferJavaTimeOverload", "deprecation"})
   // we have to use the deprecated setEncoder overload to test it
   void invalidConfig() {
-    assertThatThrownBy(() -> ZipkinSpanExporter.builder().setReadTimeout(-1, TimeUnit.MILLISECONDS))
+    assertThatThrownBy(() -> ZipkinSpanExporter.builder().setReadTimeout(0, TimeUnit.MILLISECONDS))
         .isInstanceOf(IllegalArgumentException.class)
-        .hasMessage("timeout must be non-negative");
+        .hasMessage("timeout must be positive");
 
     assertThatThrownBy(() -> ZipkinSpanExporter.builder().setReadTimeout(1, null))
         .isInstanceOf(NullPointerException.class)

sdk/logs/src/main/java/io/opentelemetry/sdk/logs/export/BatchLogRecordProcessorBuilder.java

@@ -70,7 +70,7 @@ long getScheduleDelayNanos() {
    */
   public BatchLogRecordProcessorBuilder setExporterTimeout(long timeout, TimeUnit unit) {
     requireNonNull(unit, "unit");
-    checkArgument(timeout >= 0, "timeout must be non-negative");
+    checkArgument(timeout > 0, "timeout must be positive");
     exporterTimeoutNanos = unit.toNanos(timeout);
     return this;
   }

sdk/logs/src/test/java/io/opentelemetry/sdk/logs/export/BatchLogRecordProcessorTest.java

@@ -99,9 +99,9 @@ void builderInvalidConfig() {
     assertThatThrownBy(
             () ->
                 BatchLogRecordProcessor.builder(mockLogRecordExporter)
-                    .setExporterTimeout(-1, TimeUnit.MILLISECONDS))
+                    .setExporterTimeout(0, TimeUnit.MILLISECONDS))
         .isInstanceOf(IllegalArgumentException.class)
-        .hasMessage("timeout must be non-negative");
+        .hasMessage("timeout must be positive");
     assertThatThrownBy(
             () ->
                 BatchLogRecordProcessor.builder(mockLogRecordExporter).setExporterTimeout(1, null))

sdk/trace/src/main/java/io/opentelemetry/sdk/trace/export/BatchSpanProcessorBuilder.java

@@ -78,7 +78,7 @@ long getScheduleDelayNanos() {
    */
   public BatchSpanProcessorBuilder setExporterTimeout(long timeout, TimeUnit unit) {
     requireNonNull(unit, "unit");
-    checkArgument(timeout >= 0, "timeout must be non-negative");
+    checkArgument(timeout > 0, "timeout must be positive");
     exporterTimeoutNanos = unit.toNanos(timeout);
     return this;
   }

sdk/trace/src/test/java/io/opentelemetry/sdk/trace/export/BatchSpanProcessorTest.java

@@ -111,9 +111,9 @@ void builderInvalidConfig() {
     assertThatThrownBy(
             () ->
                 BatchSpanProcessor.builder(mockSpanExporter)
-                    .setExporterTimeout(-1, TimeUnit.MILLISECONDS))
+                    .setExporterTimeout(0, TimeUnit.MILLISECONDS))
         .isInstanceOf(IllegalArgumentException.class)
-        .hasMessage("timeout must be non-negative");
+        .hasMessage("timeout must be positive");
     assertThatThrownBy(
             () -> BatchSpanProcessor.builder(mockSpanExporter).setExporterTimeout(1, null))
         .isInstanceOf(NullPointerException.class)