Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update span name if route is known #205

Merged
merged 5 commits into from
Oct 19, 2023
Merged

Conversation

cedricziel
Copy link
Contributor

@cedricziel cedricziel commented Oct 19, 2023

As per the semantic conventions, span names should include the route name if available:

HTTP server span names SHOULD be {method} {http.route} if there is a (low-cardinality) http.route available (see below for the exact definition of the {method} placeholder).

This changes updates the span names for the Symfony auto-instrumentation to use {http.request.method} {http.route} in cases where it is available.

@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

Merging #205 (d65a549) into main (a66b1f1) will increase coverage by 0.51%.
The diff coverage is 0.00%.

❗ Current head d65a549 differs from pull request most recent head 230ae91. Consider uploading reports for the commit 230ae91 to get more accurate results

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #205      +/-   ##
============================================
+ Coverage     33.13%   33.65%   +0.51%     
+ Complexity      852      839      -13     
============================================
  Files            76       75       -1     
  Lines          3247     3197      -50     
============================================
  Hits           1076     1076              
+ Misses         2171     2121      -50     
Flag Coverage Δ
7.4 46.34% <ø> (ø)
8.0 32.70% <0.00%> (-0.36%) ⬇️
8.1 35.93% <0.00%> (+2.83%) ⬆️
8.2 36.91% <0.00%> (+3.83%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...rumentation/Symfony/src/SymfonyInstrumentation.php 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a66b1f1...230ae91. Read the comment docs.

@cedricziel cedricziel marked this pull request as ready for review October 19, 2023 20:15
@cedricziel cedricziel requested a review from a team October 19, 2023 20:15
@brettmc brettmc merged commit 6ec34b4 into open-telemetry:main Oct 19, 2023
58 checks passed
@cedricziel cedricziel deleted the patch-3 branch October 19, 2023 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants