-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Laravel: InstrumentationInterface experimentation. #252
Laravel: InstrumentationInterface experimentation. #252
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #252 +/- ##
============================================
+ Coverage 84.38% 85.64% +1.26%
+ Complexity 983 902 -81
============================================
Files 89 78 -11
Lines 3946 3519 -427
============================================
- Hits 3330 3014 -316
+ Misses 616 505 -111
Flags with carried forward coverage won't be shown. Click here to find out more. see 19 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
public function activate(): bool | ||
{ | ||
if (!$this->init()) { | ||
return false; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was unsure of the expected usage of this, based on these comments.
503fd8f
to
4e98ca8
Compare
4e98ca8
to
9802c35
Compare
ab0f063
to
511b09a
Compare
I was curious as to how the
InstrumentationInterface
may be used.This appears to work but does not pass under test - I suspect because there are multiple
hook()
registered.This is more than likely throwaway, so please feel free to tear it apart!
Removed
_register.php
, but it might be necessary to include something akin to:Dependencies: