Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement rule-based sampler #279

Merged
merged 15 commits into from
Sep 12, 2024

Merge pull request #1 from ChrisLightfootWild/sampler/gitattributes

75c26b6
Select commit
Loading
Failed to load commit list.
Merged

implement rule-based sampler #279

Merge pull request #1 from ChrisLightfootWild/sampler/gitattributes
75c26b6
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Sep 12, 2024 in 0s

82.68% (+0.23%) compared to 727236e

View this Pull Request on Codecov

82.68% (+0.23%) compared to 727236e

Details

Codecov Report

Attention: Patch coverage is 32.14286% with 114 lines in your changes missing coverage. Please review.

Project coverage is 82.68%. Comparing base (727236e) to head (75c26b6).
Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
...leBased/src/ComponentProvider/SamplerRuleBased.php 0.00% 28 Missing ⚠️
...sed/src/ComponentProvider/SamplingRuleSpanKind.php 0.00% 26 Missing ⚠️
...ed/src/ComponentProvider/SamplingRuleAttribute.php 0.00% 20 Missing ⚠️
...sed/src/ComponentProvider/SamplingRuleSpanName.php 0.00% 14 Missing ⚠️
...leBased/src/ComponentProvider/SamplingRuleLink.php 0.00% 13 Missing ⚠️
...Based/src/ComponentProvider/SamplingRuleParent.php 0.00% 13 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #279      +/-   ##
============================================
+ Coverage     82.45%   82.68%   +0.23%     
+ Complexity     1073      948     -125     
============================================
  Files           104       89      -15     
  Lines          4480     3807     -673     
============================================
- Hits           3694     3148     -546     
+ Misses          786      659     -127     
Files with missing lines Coverage Δ
src/Sampler/RuleBased/src/RuleBasedSampler.php 100.00% <100.00%> (ø)
src/Sampler/RuleBased/src/RuleSet.php 100.00% <100.00%> (ø)
...mpler/RuleBased/src/SamplingRule/AttributeRule.php 100.00% <100.00%> (ø)
...rc/Sampler/RuleBased/src/SamplingRule/LinkRule.php 100.00% <100.00%> (ø)
.../Sampler/RuleBased/src/SamplingRule/ParentRule.php 100.00% <100.00%> (ø)
...ampler/RuleBased/src/SamplingRule/SpanKindRule.php 100.00% <100.00%> (ø)
...ampler/RuleBased/src/SamplingRule/SpanNameRule.php 100.00% <100.00%> (ø)
...leBased/src/ComponentProvider/SamplingRuleLink.php 0.00% <0.00%> (ø)
...Based/src/ComponentProvider/SamplingRuleParent.php 0.00% <0.00%> (ø)
...sed/src/ComponentProvider/SamplingRuleSpanName.php 0.00% <0.00%> (ø)
... and 3 more

... and 33 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 727236e...75c26b6. Read the comment docs.