[symfony] Fix: Set span status according to otel convention #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #308 +/- ##
============================================
- Coverage 80.33% 80.17% -0.16%
- Complexity 1026 1028 +2
============================================
Files 98 98
Lines 4114 4268 +154
============================================
+ Hits 3305 3422 +117
- Misses 809 846 +37
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 49 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
brettmc
approved these changes
Oct 18, 2024
|
Thanks, @technimad-splunk . It looks like there is a linting error in Symfony (see checks), can you please fix that? |
agoallikmaa
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only set error status on span if we know the response code is 500 or higher.
Addresses open-telemetry/opentelemetry-php#1403
In Symfony any error is handled as an exception. The instrumentation added an error status to any span when an exception occurred. This is not in line with the spec. For span kinds of server, the error status must ONLY be set for response codes of 500 and higher.
Earlier improvement was done in PR #295, but that fix wasn't sufficient.